Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use GitHub's alert syntax #1234

Merged
merged 1 commit into from
Dec 15, 2023
Merged

Use GitHub's alert syntax #1234

merged 1 commit into from
Dec 15, 2023

Conversation

spenserblack
Copy link
Collaborator

@o2sh
Copy link
Owner

o2sh commented Dec 15, 2023

I love it, thanks for sharing @spenserblack I've also updated the Readme.md to make use of it 8a5cf38

@o2sh o2sh merged commit 3f778eb into o2sh:main Dec 15, 2023
1 check passed
@o2sh o2sh added the doc label Dec 15, 2023
@spenserblack spenserblack deleted the docs/alert branch December 15, 2023 22:05
@o2sh
Copy link
Owner

o2sh commented Dec 16, 2023

Unfortunately, it seems like Markdown Alerts are a Github only feature. It doesn't display correctly on crates.io and vscode for example. I will revert 8a5cf38

@o2sh o2sh mentioned this pull request Dec 16, 2023
2 tasks
@spenserblack
Copy link
Collaborator Author

Ah, yeah, I agree. This syntax can really only be used in GitHub-only files.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants