add language bar #585
Merged
add language bar #585
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spenserblack
approved these changes
Feb 20, 2022
| @@ -304,27 +304,58 @@ impl Info { | |||
| } | |||
|
|
|||
| fn get_language_field(&self, title: &str) -> String { | |||
| let mut language_field = String::from(""); | |||
|
|
|||
| let language_bar_length = 26; | |||
There was a problem hiding this comment.
Based on the screenshot, this seems to line up nicely. If this was 29 characters, it might be more symmetrical with the ASCII art, which maxes out at 40 characters wide. (29 + "Languages: ".len()).
There was a problem hiding this comment.
If the language bar's length were to be fixed, this would indeed make sense. However with the possible extra characters, this value can go up to 35, or 46 with "Languages: ".len().
Collects the language bar to a string to reduce String mutations.
spenserblack
approved these changes
Feb 20, 2022
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#584
Remarks:
The language bar is 26 characters long (arbitrary value). However, in some cases it can be longer. Indeed, if a language's weight in the distribution is too small to account for a whole character, I do a cmp::Max(val, 1) so that, it will still appear in the language bar. This may not be optimal 🤔
As discussed before, if the terminal doesn't support true color, we fallback to a default color palette: