Turn InfoField into a trait (big refactoring) #755
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
o2sh
changed the title
o2sh
requested review from
spenserblack,
HallerPatrick and
Byron
as code owners
spenserblack
approved these changes
Sep 4, 2022
src/info/deps/mod.rs
Outdated
Comment on lines
66
to
69
| InfoFieldValue { | ||
| r#type: InfoType::Dependencies, | ||
| value: self.dependencies.to_string(), | ||
| } |
There was a problem hiding this comment.
I wonder if .type should be an associated constant, and the return type of value simplified to just a String?
There was a problem hiding this comment.
Very nice! Thanks for the hint, it simplifies things even more 46d67de
I also removed the InfoFieldValueGetter trait
spenserblack
approved these changes
Sep 6, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces the InfoField trait which is implemented by all info lines.
Each implementation of InfoField lives in its own file and encapsulates its logic for formatting and data fetching. As a result, info/mod.rs and repo.rs (renamed to git.rs) are now considerably smaller.
Additional improvements: