Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Info struct to holds a Vec<InfoField> #911

Merged
merged 5 commits into from
Dec 30, 2022
Merged

Info struct to holds a Vec<InfoField> #911

merged 5 commits into from
Dec 30, 2022

Conversation

o2sh
Copy link
Owner

@o2sh o2sh commented Dec 30, 2022 •
edited
Loading

Part 2 of #755,

Now that all info fields implement the InfoField trait, we can put them inside a Vector and iterate over to simplify the fmt() method of std::fmt::Display.

@o2sh o2sh removed the request for review from Byron December 30, 2022 17:09
spenserblack
spenserblack approved these changes Dec 30, 2022
View reviewed changes
Copy link
Collaborator

@spenserblack spenserblack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is awesome! It looks like it will be much easier to maintain stat lines, now 🚀

src/info/mod.rs Outdated Show resolved Hide resolved
@o2sh o2sh changed the title Info struct to hold a Vec<InfoField> Info struct to holds a Vec<InfoField> Dec 30, 2022
@o2sh o2sh merged commit 4a3ef8c into main Dec 30, 2022
@o2sh o2sh deleted the chore/vec-of-info-fields branch December 30, 2022 20:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@spenserblack spenserblack spenserblack approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@o2sh @spenserblack