Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding language verilog #490 #789

Merged
merged 3 commits into from
Oct 3, 2022
Merged

adding language verilog #490 #789

merged 3 commits into from
Oct 3, 2022

Conversation

atluft
Copy link
Contributor

@atluft atluft commented Oct 3, 2022

Adding language verilog.

Verilog Hardware Description Language
Idea for icon from Visual Code verilog file icon here

image

Note that tokei has issue identify verilog files

I was surprised too, usually use *.v but tokei wants *.vg so keep that in mind. That shouldn't impact the usage here, only remind users that the issue is upstream.

TESTING

git clone https://github.com/alexforencich/verilog-ethernet.git
cd verilog-ethernet
find . -name *.v -exec mv \{\} \{\}.vg \;

languages.yaml Outdated Show resolved Hide resolved
languages.yaml Outdated Show resolved Hide resolved
Copy link
Owner

@o2sh o2sh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very well done @atluft 👍

Left a few remarks.

straighter lines look better

Co-authored-by: Ossama Hjaji <ossama-hjaji@live.fr>
@atluft
Copy link
Contributor Author

atluft commented Oct 3, 2022

@o2sh
Thanks, all valuable feedback.

@o2sh o2sh self-requested a review October 3, 2022 22:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants