Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update documentation in gems #633

Merged
merged 6 commits into from
Jan 10, 2024

Conversation

jhanca-robotecai
Copy link
Contributor

@jhanca-robotecai jhanca-robotecai commented Dec 14, 2023

  • Update documentation in ProteusRobot and RosRobotSample gems, add images
  • Add documentation in WarehouseSample gem, add images
  • Add documentation in WarehouseAutomation gem readme, add images

Gems/ProteusRobot/README.md Show resolved Hide resolved
Gems/ProteusRobot/README.md Outdated Show resolved Hide resolved
Gems/ProteusRobot/README.md Outdated Show resolved Hide resolved
Gems/ProteusRobot/README.md Outdated Show resolved Hide resolved
Gems/ProteusRobot/README.md Outdated Show resolved Hide resolved
Gems/RosRobotSample/README.md Outdated Show resolved Hide resolved
Gems/RosRobotSample/README.md Outdated Show resolved Hide resolved
Gems/RosRobotSample/README.md Outdated Show resolved Hide resolved
Gems/WarehouseAssets/README.md Outdated Show resolved Hide resolved
Gems/WarehouseAutomation/README.md Outdated Show resolved Hide resolved
Copy link
Contributor Author

@jhanca-robotecai jhanca-robotecai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the detailed review.

Gems/ProteusRobot/gem.json Show resolved Hide resolved
Gems/ProteusRobot/README.md Outdated Show resolved Hide resolved
Gems/ProteusRobot/README.md Outdated Show resolved Hide resolved
Gems/ProteusRobot/README.md Show resolved Hide resolved
Gems/WarehouseAutomation/README.md Outdated Show resolved Hide resolved
Copy link
Contributor

@adamdbrw adamdbrw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I made some suggestions to apply, otherwise I think it is ready

Gems/RosRobotSample/gem.json Outdated Show resolved Hide resolved
Gems/WarehouseAutomation/README.md Outdated Show resolved Hide resolved
Gems/WarehouseAutomation/README.md Outdated Show resolved Hide resolved
Copy link
Contributor

@michalpelka michalpelka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add all images without LFS - to have it rendered properly.

jhanca-robotecai and others added 6 commits January 4, 2024 11:23
Signed-off-by: Jan Hanca <jan.hanca@robotec.ai>
Signed-off-by: Jan Hanca <jan.hanca@robotec.ai>
Signed-off-by: Jan Hanca <jan.hanca@robotec.ai>
Signed-off-by: Jan Hanca <jan.hanca@robotec.ai>
Co-authored-by: Adam Dąbrowski <adam.dabrowski@robotec.ai>
Signed-off-by: Jan Hanca <jan.hanca@robotec.ai>
Signed-off-by: Jan Hanca <jan.hanca@robotec.ai>
Co-authored-by: Adam Dąbrowski <adam.dabrowski@robotec.ai>
@jhanca-robotecai
Copy link
Contributor Author

Rebased and force-pushed on top of development to rerun and fix Jenkins output.

@michalpelka michalpelka merged commit 650bfa1 into o3de:development Jan 10, 2024
2 checks passed
@jhanca-robotecai jhanca-robotecai deleted the jh/add_gems_readme branch January 10, 2024 12:37
jhanca-robotecai added a commit to RobotecAI/o3de-extras that referenced this pull request Apr 24, 2024
* update ProteusRobot and RosRobotSample gems docs
* update WarehouseSample readme
* add WarehouseAutomation gem readme
* code review
* fix ROS2 -> ROS 2
* code review: add readme images
---------
Signed-off-by: Jan Hanca <jan.hanca@robotec.ai>
Co-authored-by: Adam Dąbrowski <adam.dabrowski@robotec.ai>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants