Cherry-picks for 23103 point-release #690
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes SIGINT and SIGTERM handling to adequately shut down o3de processes that host an rclcpp instance, especially to fix process termination via `CTRL+C` keyboard command Cf. ros2/rclcpp#317 (comment) Signed-off-by: Lars Gleim <lgleim@users.noreply.github.com> Co-authored-by: Adam Dąbrowski <adam.dabrowski@robotec.ai>
* update ProteusRobot and RosRobotSample gems docs * update WarehouseSample readme * add WarehouseAutomation gem readme * code review * fix ROS2 -> ROS 2 * code review: add readme images --------- Signed-off-by: Jan Hanca <jan.hanca@robotec.ai> Co-authored-by: Adam Dąbrowski <adam.dabrowski@robotec.ai>
Adjusted Twist component to apply twist in every phycisc step. - Improves the accuracy of the twist applied to the robot. - Enable simple simulation of flying robots. --------- Signed-off-by: Michał Pełka <michal.pelka@robotec.ai> Co-authored-by: Jan Hanca <jan.hanca@robotec.ai> Co-authored-by: Steve Pham <82231385+spham-amzn@users.noreply.github.com> Co-authored-by: Adam Dąbrowski <adam.dabrowski@robotec.ai>
* Add pip requirements for ROS2 Gem * Change test level to DefaultLevel --------- Signed-off-by: Mateusz Wasilewski <mateusz.wasilewski@robotec.ai> Signed-off-by: Mateusz Wasilewski <mateuszwasilewski12@gmail.com> Co-authored-by: Jan Hanca <jan.hanca@robotec.ai>
Signed-off-by: Jan Hanca <jan.hanca@robotec.ai>
Signed-off-by: Shauna Gordon <shauna@shaunagordon.com>
Building a project with this template throws "you cannot bind an lvalue to an rvalue reference" error. Copilot suggests removing the template declaration in the call to fix this. Signed-off-by: Shauna Gordon <shauna@shaunagordon.com>
Signed-off-by: Jan Hanca <jan.hanca@robotec.ai>
Signed-off-by: Jan Hanca <jan.hanca@robotec.ai>
jhanca-robotecai
changed the title
|
Tested with |
It casued compilation error on engine-centric build. It is manually cherrypicked from PR o3de#665. Signed-off-by: Michał Pełka <michal.pelka@robotec.ai> Co-authored-by: Steve Pham <82231385+spham-amzn@users.noreply.github.com>
|
Tested with the project-centric approach with 3 robotics templates. |
michalpelka
approved these changes
Apr 25, 2024
nick-l-o3de
approved these changes
Apr 25, 2024
|
Started AR build. |
|
Build succeeded, but status was not reported back to GH: |
|
I've tested with the https://github.com/o3de/o3de/tree/point-release/23103. And ros2projectTemplate. Works as intended. |
|
As the AR job succeeded, but not reported back here, I'll go ahead with the bypass and merge this |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR collects changes that should be integrated into the next point-release. Please find the list below:
#633 - updates in the documentation that are common for
mainanddevelopment#636 - fix for rclcpp SIGINT and SIGTERM handling (it was not handled in 2310.2)
#645 - fix in Twist Robot Control that allows to move the robot more smoothly
#663 - fix of the ROS2 Python tests that did not work in 2310.2
#677 - fix in scale calculation applied to a sensor (sensors were not placed correctly when scaled)
#680 - fix of the multiplayer template which did not work in 2310.2
#682 - removal of the unused texture files that were duplicated along different Gems
#665 - Partially cherry-picked to enable compilation of WarehouseAutomationGem with a project-centric approach.
Additionally, please find the list of changes that are NOT included in this PR even though they might look like a good candidate for the point-release at first sight:
#613, #654 - changes in spawner rely on multiple other changes, which makes it too big for the point-release
#642 - this fix changes the code that does not exist on the main branch yet
#676, #681 - the project templates were heavily modified, including changes that require changes in o3de and more changes from o3de-extras (modified ROS2FrameEditorComponent); it would require a complete rework to be applicable in the point-release
I built three project templates to test the changes: