Fix rclcpp SIGINT & SIGTERM handling #636
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes SIGINT handling to adequately shut down o3de processes that host an rclcpp instance, especially to fix process termination via `CTRL+C` keyboard command Cf. ros2/rclcpp#317 (comment) Signed-off-by: Lars Gleim <lgleim@users.noreply.github.com>
spham-amzn
reviewed
Dec 18, 2023
lgleim
commented
Dec 19, 2023
Signed-off-by: Lars Gleim <lgleim@users.noreply.github.com>
lgleim
changed the title
adamdbrw
reviewed
Dec 19, 2023
Co-authored-by: Adam Dąbrowski <adam.dabrowski@robotec.ai> Signed-off-by: Lars Gleim <lgleim@users.noreply.github.com>
adamdbrw
approved these changes
Dec 19, 2023
|
Good contribution, thank you! |
|
Tested, works as expected. Thank you @lgleim ! |
michalpelka
approved these changes
Dec 19, 2023
spham-amzn
approved these changes
Dec 19, 2023
michalpelka
pushed a commit
to RobotecAI/o3de-extras
that referenced
this pull request
Jan 16, 2024
Fixes SIGINT and SIGTERM handling to adequately shut down o3de processes that host an rclcpp instance, especially to fix process termination via `CTRL+C` keyboard command Cf. ros2/rclcpp#317 (comment) Signed-off-by: Lars Gleim <lgleim@users.noreply.github.com> Co-authored-by: Adam Dąbrowski <adam.dabrowski@robotec.ai>
styczen
pushed a commit
to RobotecAI/o3de-extras
that referenced
this pull request
Jan 17, 2024
Fixes SIGINT and SIGTERM handling to adequately shut down o3de processes that host an rclcpp instance, especially to fix process termination via `CTRL+C` keyboard command Cf. ros2/rclcpp#317 (comment) Signed-off-by: Lars Gleim <lgleim@users.noreply.github.com> Co-authored-by: Adam Dąbrowski <adam.dabrowski@robotec.ai>
zakmat
pushed a commit
to RobotecAI/o3de-extras
that referenced
this pull request
Feb 13, 2024
Fixes SIGINT and SIGTERM handling to adequately shut down o3de processes that host an rclcpp instance, especially to fix process termination via `CTRL+C` keyboard command Cf. ros2/rclcpp#317 (comment) Signed-off-by: Lars Gleim <lgleim@users.noreply.github.com> Co-authored-by: Adam Dąbrowski <adam.dabrowski@robotec.ai>
jhanca-robotecai
pushed a commit
to RobotecAI/o3de-extras
that referenced
this pull request
Apr 24, 2024
Fixes SIGINT and SIGTERM handling to adequately shut down o3de processes that host an rclcpp instance, especially to fix process termination via `CTRL+C` keyboard command Cf. ros2/rclcpp#317 (comment) Signed-off-by: Lars Gleim <lgleim@users.noreply.github.com> Co-authored-by: Adam Dąbrowski <adam.dabrowski@robotec.ai>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes SIGINT & SIGTERM handling to adequately shut down o3de processes that host an rclcpp instance, especially to fix process termination via
CTRL+Ckeyboard commandCf. ros2/rclcpp#317 (comment)