Fix ROS2 python tests #663
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Mateusz Wasilewski <mateusz.wasilewski@robotec.ai>
Signed-off-by: Mateusz Wasilewski <mateusz.wasilewski@robotec.ai>
There was a problem hiding this comment.
Tested on o3de cec608023e
Tests passed correctly after changing the default level name - my project did not have DefaultLevel level.
diff --git a/Gems/ROS2/Code/PythonTests/tests/SmokeTests_EnterGameModeWorks.py b/Gems/ROS2/Code/PythonTests/tests/SmokeTests_EnterGameModeWorks.py
index e97d406b..7c5c728b 100644
--- a/Gems/ROS2/Code/PythonTests/tests/SmokeTests_EnterGameModeWorks.py
+++ b/Gems/ROS2/Code/PythonTests/tests/SmokeTests_EnterGameModeWorks.py
@@ -72,7 +72,7 @@ def SmokeTest_EnterGameModeWorks():
# - /tf
# - /tf_static
# - /clock
- helper.open_level(level="DefaultLevel", directory='')
+ helper.open_level(level="DemoLevel", directory='')
topics_before_game_mode = check_topics()
Gems/ROS2/Code/PythonTests/tests/SmokeTests_EnterGameModeWorks.py
Outdated
Show resolved
Hide resolved
Co-authored-by: Jan Hanca <jan.hanca@robotec.ai> Signed-off-by: Mateusz Wasilewski <mateuszwasilewski12@gmail.com>
pijaro
approved these changes
Feb 13, 2024
| helper.open_level(level="Warehouse", directory='') | ||
| # Open the level called "DefaultLevel". | ||
| # We use a DefaultLevel level for a smoke test. | ||
| # ROS2 System Component should publish topics listed below regardless of level |
There was a problem hiding this comment.
Nit: ROS2SystemComponent if referring to the "ROS2" gem component, or ROS 2 system component if referring to ROS 2 as a general behavior.
michalpelka
approved these changes
Feb 22, 2024
adamkrawczyk
pushed a commit
to RobotecAI/o3de-extras
that referenced
this pull request
Apr 10, 2024
* Add pip requirements for ROS2 Gem * Change test level to DefaultLevel --------- Signed-off-by: Mateusz Wasilewski <mateusz.wasilewski@robotec.ai> Signed-off-by: Mateusz Wasilewski <mateuszwasilewski12@gmail.com> Co-authored-by: Jan Hanca <jan.hanca@robotec.ai>
jhanca-robotecai
added a commit
to RobotecAI/o3de-extras
that referenced
this pull request
Apr 24, 2024
* Add pip requirements for ROS2 Gem * Change test level to DefaultLevel --------- Signed-off-by: Mateusz Wasilewski <mateusz.wasilewski@robotec.ai> Signed-off-by: Mateusz Wasilewski <mateuszwasilewski12@gmail.com> Co-authored-by: Jan Hanca <jan.hanca@robotec.ai>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
fixes #575
resolves #574
Adds pip dependencies (connected to ros2) to
o3de/pythonif ros2 gem is enabled.How was this PR tested?
On non headless device run:
On o3de commit
5ae4e51252