Update PhysX5 references for robots related files #665
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Steve Pham <82231385+spham-amzn@users.noreply.github.com>
michalpelka
approved these changes
Feb 2, 2024
lemonade-dm
requested changes
Feb 6, 2024
Templates/Ros2FleetRobotTemplate/Template/Registry/physxdebugconfiguration.setreg
Show resolved
Hide resolved
There was a problem hiding this comment.
I think the repo.json changes will break existing older versions of the ros2 gem for anyone who has added this remote repo (not canonical). I left some comments related to how to update it. Mostly stuff like bumping gem versions, using the cli. Also, it looks like both those templates are using the older (now removed) enabled_gems.cmake file. Not sure if you want to upgrade those templates in this PR though.
- Updated gems and template versioning info - Minor fixes * Update dependencies to updated versions of gems * Fix unnnecessary target with empty files (WarehouseAutomation.Editor.Private.Object) causing the following error: - CMake can not determine linker language for target: WarehouseAutomation.Editor.Private.Object * Disable test target for the arehouse editor since there are no tests defined * Removed 'enabled_gems.cmake' - Removed file from the ROS related templates and updated its EngineFinder.cmake accordingly - Moved dependencies to the template's project.json Signed-off-by: Steve Pham <82231385+spham-amzn@users.noreply.github.com>
Signed-off-by: Steve Pham <82231385+spham-amzn@users.noreply.github.com>
lemonade-dm
approved these changes
Feb 7, 2024
…ompatibility Signed-off-by: Steve Pham <82231385+spham-amzn@users.noreply.github.com>
Signed-off-by: Steve Pham <82231385+spham-amzn@users.noreply.github.com>
AMZN-alexpete
approved these changes
Feb 7, 2024
adamkrawczyk
pushed a commit
to RobotecAI/o3de-extras
that referenced
this pull request
Apr 10, 2024
* Update PhysX5 references for robots related files * Update repo.json - Updated gems and template versioning info - Minor fixes * Update dependencies to updated versions of gems * Fix unnnecessary target with empty files (WarehouseAutomation.Editor.Private.Object) causing the following error: - CMake can not determine linker language for target: WarehouseAutomation.Editor.Private.Object * Disable test target for the arehouse editor since there are no tests defined * Removed 'enabled_gems.cmake' - Removed file from the ROS related templates and updated its EngineFinder.cmake accordingly - Moved dependencies to the template's project.json Signed-off-by: Steve Pham <82231385+spham-amzn@users.noreply.github.com>
michalpelka
added a commit
to RobotecAI/o3de-extras
that referenced
this pull request
Apr 25, 2024
It casued compilation error on engine-centric build. It is manually cherrypicked from PR o3de#665. Signed-off-by: Michał Pełka <michal.pelka@robotec.ai> Co-authored-by: Steve Pham <82231385+spham-amzn@users.noreply.github.com>
michalpelka
added a commit
to RobotecAI/o3de-extras
that referenced
this pull request
Apr 25, 2024
It casued compilation error on engine-centric build. It is manually cherrypicked from PR o3de#665. Signed-off-by: Michał Pełka <michal.pelka@robotec.ai> Co-authored-by: Steve Pham <82231385+spham-amzn@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This updates all the robot related project templates and gems (ROS2) to reference 'PhysX5' instead of 'PhysX' for simulation, now that both gems will be available at the same time (without the need of a cmake flag when creating the project from source). (Refer to o3de/o3de#17436 ).
Update templates that relate to ROS2 to tag version 3.1.0
How was this PR tested?
From a source build, created projects from the following templates:
From the installer (SDK) build performed the same project creation workflows above
Built and launch rVIZ for each of the templates above.
RFC: o3de/sig-simulation#85