Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for 'Coordinate system change' modifier to PhysX tab in Scene Settings #15028

Merged

Conversation

moraaar
Copy link
Contributor

@moraaar moraaar commented Mar 9, 2023

What does this PR do?

Added support for "Coordinate system change" modifier to PhysX tab so the users can add the transformation to the PhysX collider to match the transformation applied to the Mesh.

Fixes #14649
Fixes #11330
Fixes #2426

Modifier in Scene settings PhysX tab:
image

Before:
image

After:
image

How was this PR tested?

Manually tested in a level using a Mesh Collider with a mesh exported as:

  • primitive
  • primitive with decomposition
  • convex
  • convex with decomposition
  • triangle mesh

Tested with "Coordinate system change" modifier simple and advance modes.

…cene Settings

Signed-off-by: moraaar <moraaar@amazon.com>
@nick-l-o3de
Copy link
Contributor

Kinda makes me wish there was a way (hook, callback, bus, ...) for scripting or code to pre-modify the entire in-memory scene before the processing steps so that we wouldn't have to duplicate modifiers into every system.

@moraaar
Copy link
Contributor Author

moraaar commented Mar 9, 2023

Kinda makes me wish there was a way (hook, callback, bus, ...) for scripting or code to pre-modify the entire in-memory scene before the processing steps so that we wouldn't have to duplicate modifiers into every system.

Yeah, we also considered having a "common" place to put the modifier so it's only added once (Solution 2 in #14649), but we inclined towards the current solution as a short term fix.

@moraaar moraaar merged commit d0bf5e2 into o3de:development Mar 10, 2023
@moraaar moraaar deleted the PhysXCoordinateSystemModifier branch March 10, 2023 09:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants