Change Vulkan RHI CommandList::SetStreamBuffers to not do 2 memory allocation per draw by using fixed_vector #6393
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…location per draw by using fixed_vector Signed-off-by: rgba16f <82187279+rgba16f@users.noreply.github.com>
gadams3
approved these changes
Dec 14, 2021
wintermute-motherbrain
approved these changes
Dec 14, 2021
nemerle
reviewed
Dec 14, 2021
| AZStd::vector<VkBuffer> nativeBuffers(numBuffers, VK_NULL_HANDLE); | ||
| AZStd::vector<VkDeviceSize> offsets(numBuffers, 0); | ||
| AZStd::fixed_vector<VkBuffer, RHI::Limits::Pipeline::StreamCountMax> nativeBuffers(numBuffers, VK_NULL_HANDLE); | ||
| AZStd::fixed_vector<VkDeviceSize, RHI::Limits::Pipeline::StreamCountMax> offsets(numBuffers, 0); |
There was a problem hiding this comment.
I'm not sure if you'd want to add it to this PR, but there's another small gain to be had at this point:
for (uint32_t i = 0; i < numBuffers; ++i)
{
const RHI::StreamBufferView& bufferView = streams[i + interval.m_min];
if (!bufferView.GetBuffer())
{
continue; // in this case entries in nativeBuffers and offsets are unchanged from their state pre-initialized above
}
const auto* bufferMemoryView = static_cast<const Buffer*>(bufferView.GetBuffer())->GetBufferMemoryView();
nativeBuffers[i] = bufferMemoryView->GetNativeBuffer();
offsets[i] = bufferMemoryView->GetOffset() + bufferView.GetByteOffset();
}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: rgba16f 82187279+rgba16f@users.noreply.github.com