Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add stylelint plugin link and global command #11

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

srayeskyo3
Copy link

2 things that I had to do, might be useful to add to the readme

Copy link

@sgengler sgengler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@srayeskyo3 looks great! One suggestion for a possible addition as well.

Comment on lines +949 to +953
You may have to install stylelint globally:
```
npm install stylelint -g
```

Copy link

@sgengler sgengler Feb 10, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@srayeskyo3 yes I think this is a good note as this will confuse people

Additionally, instead of installing globally you can also add a script in package.json to run it as well, like:

"scripts": {
    "styelint": "stylelint foo/**/*.scss'",
  ...
}

then run with npm run stylelint or yarn stylelint

would probably be good to add a note for that as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants