New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
new.go Transport misses proxy #183
Closed
evelynmitchell opened this issue
Apr 21, 2022
· 1 comment
· Fixed by #185 or oVirt/ovirt-engine-sdk-go#239
Closed
new.go Transport misses proxy #183
evelynmitchell opened this issue
Apr 21, 2022
· 1 comment
· Fixed by #185 or oVirt/ovirt-engine-sdk-go#239
Labels
bug
Something isn't working
Comments
Hello @evelynmitchell thank you very much for the issue and the PR, most of the team is out this week and we will get back to this issue early next week. |
janosdebugs
added a commit
that referenced
this issue
Apr 27, 2022
janosdebugs
added a commit
to oVirt/ovirt-engine-sdk-go
that referenced
this issue
Apr 27, 2022
janosdebugs
added a commit
that referenced
this issue
Apr 27, 2022
janosdebugs
added a commit
that referenced
this issue
Apr 27, 2022
janosdebugs
added a commit
to oVirt/ovirt-engine-sdk-go
that referenced
this issue
Apr 27, 2022
janosdebugs
pushed a commit
to oVirt/go-ovirt
that referenced
this issue
Apr 27, 2022
…t#183: Proxy support. GitHub build: 19.
janosdebugs
added a commit
that referenced
this issue
Apr 27, 2022
janosdebugs
added a commit
that referenced
this issue
Apr 27, 2022
janosdebugs
added a commit
that referenced
this issue
Apr 27, 2022
janosdebugs
added a commit
that referenced
this issue
Apr 27, 2022
janosdebugs
added a commit
that referenced
this issue
Apr 27, 2022
janosdebugs
added a commit
that referenced
this issue
Apr 27, 2022
janosdebugs
added a commit
that referenced
this issue
Apr 27, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Describe the bug
At lines 138 to 141, where the http Client is set up, the Proxy is not mentioned.
This should include
Proxy: http.ProxyFromEnvironment
In order to correctly pick up the Proxy from the environment.
To Reproduce
Set up a proxy in the test environment that is required for any network traffic to pass externally, such as an OAuth proxy.
Without this line, the connection to the larger network should fail.
With this line, the connection should succeed, after connecting to the proxy.
Expected behavior
When a proxy is definined in the environment, it is used.
The text was updated successfully, but these errors were encountered: