Issue ovirt/go-ovirt-client#183: Proxy support #239
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the Change
This PR partially fixes oVirt/go-ovirt-client#183 and adds support for setting a proxy server on the go-ovirt level. The final fix is added by oVirt/go-ovirt-client#185.
Alternate Designs
Hard-coding the proxy from environment in this library.
Benefits
It is testable.
Possible Drawbacks
More complex.
Verification Process
The go-ovirt-client change has a test for proxy usage. This change was added in a vendor folder to go-ovirt-client to test this change.