host-deploy: condition for adding fapolicy rules #256
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
remove ansible_distribution == 'RedHat' since we already check if the service is running. fapolicyd < 1.1 doesn't have /etc/fapolicyd/rules.d/,add check if the directory exists.
michalskrivanek
approved these changes
Apr 11, 2022
|
/ost |
arachmani
reviewed
Apr 12, 2022
| @@ -64,6 +64,11 @@ | |||
| command: vdsm-tool configure --force | |||
| changed_when: True | |||
|
|
|||
| - name: Verify fapolicyd.rules file | |||
| stat: | |||
| path: /etc/fapolicyd/fapolicyd.rules | |||
There was a problem hiding this comment.
You should check if /etc/fapolicyd/rules.d exists since you add the new rule to this directory.
There was a problem hiding this comment.
Crap, I've completely missed that, sorry :-(
Fixed in #259
mwperina
added a commit
to mwperina/ovirt-engine
that referenced
this pull request
Apr 12, 2022
Fixes fapolicy configuration path introduced in oVirt#256 Signed-off-by: Martin Perina <mperina@redhat.com>
mwperina
added a commit
to mwperina/ovirt-engine
that referenced
this pull request
Apr 12, 2022
Fixes fapolicy configuration path introduced in oVirt#256 Signed-off-by: Martin Perina <mperina@redhat.com>
mwperina
added a commit
to mwperina/ovirt-engine
that referenced
this pull request
Apr 12, 2022
Fixes fapolicy configuration path introduced in oVirt#256 Signed-off-by: Martin Perina <mperina@redhat.com>
mwperina
added a commit
that referenced
this pull request
Apr 12, 2022
Fixes fapolicy configuration path introduced in #256 Signed-off-by: Martin Perina <mperina@redhat.com>
mwperina
added a commit
to mwperina/ovirt-engine
that referenced
this pull request
Apr 12, 2022
Fixes fapolicy configuration path introduced in oVirt#256 Signed-off-by: Martin Perina <mperina@redhat.com>
mwperina
added a commit
to mwperina/ovirt-engine
that referenced
this pull request
Apr 13, 2022
Fixes fapolicy configuration path introduced in oVirt#256 Signed-off-by: Martin Perina <mperina@redhat.com>
bennyz
pushed a commit
to bennyz/ovirt-engine
that referenced
this pull request
Apr 14, 2022
Fixes fapolicy configuration path introduced in oVirt#256 Signed-off-by: Martin Perina <mperina@redhat.com>
mwperina
added a commit
that referenced
this pull request
Apr 14, 2022
Fixes fapolicy configuration path introduced in #256 Signed-off-by: Martin Perina <mperina@redhat.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
remove ansible_distribution == 'RedHat' since we already check if the service is running.
fapolicyd < 1.1 doesn't have /etc/fapolicyd/rules.d/,add check if the directory exists.