Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

host-deploy: condition for adding fapolicy rules #258

Merged
merged 2 commits into from Apr 14, 2022

Conversation

mwperina
Copy link
Member

@mwperina mwperina commented Apr 12, 2022

remove ansible_distribution == 'RedHat' since we already check if the service is running.
fapolicyd < 1.1 doesn't have /etc/fapolicyd/rules.d/,add check if the directory exists.

Backport of #256 and #259 into ovirt-engine-4.5.0.z

@mwperina mwperina requested a review from arachmani April 12, 2022 07:03
@mwperina mwperina marked this pull request as draft April 12, 2022 07:04
@mwperina mwperina changed the title host-deploy: condition for adding fapolicy rules [WIP] host-deploy: condition for adding fapolicy rules Apr 12, 2022
Copy link
Member

@sandrobonazzola sandrobonazzola left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mwperina mwperina changed the title [WIP] host-deploy: condition for adding fapolicy rules host-deploy: condition for adding fapolicy rules Apr 12, 2022
@mwperina mwperina marked this pull request as ready for review April 12, 2022 08:54
Copy link
Member

@arachmani arachmani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

hbraha and others added 2 commits April 13, 2022 11:12
remove ansible_distribution == 'RedHat' since we already check if the service is running.
fapolicyd < 1.1 doesn't have /etc/fapolicyd/rules.d/,add check if the directory exists.
Fixes fapolicy configuration path introduced in
oVirt#256

Signed-off-by: Martin Perina <mperina@redhat.com>
Copy link
Member

@sandrobonazzola sandrobonazzola left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mwperina mwperina merged commit ff203ec into oVirt:ovirt-engine-4.5.0.z Apr 14, 2022
@mwperina mwperina deleted the fapolicy-rule-backport branch April 14, 2022 11:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants