Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CI: enable ansible-lint run #484

Closed
wants to merge 1 commit into from
Closed

CI: enable ansible-lint run #484

wants to merge 1 commit into from

Conversation

mnecas
Copy link
Member

@mnecas mnecas commented Jun 22, 2022 •
edited
Loading

The CI did not run the ansible-lint tests on any role.

@mnecas mnecas requested a review from dangel101 June 22, 2022 13:09
@mnecas mnecas force-pushed the enable-ansible-lint branch 2 times, most recently from a7cea09 to d993ee1 Compare June 22, 2022 14:01
mwperina
mwperina reviewed Jun 22, 2022
View reviewed changes
Copy link
Member

@mwperina mwperina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, but we can merge it only after all issues are fixed

@mwperina mwperina requested review from sandrobonazzola and removed request for bennyz, emesika, sgratch and oliel June 22, 2022 14:33
sandrobonazzola
sandrobonazzola approved these changes Jun 22, 2022
View reviewed changes
Copy link
Member

@sandrobonazzola sandrobonazzola left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mnecas
Copy link
Member Author

mnecas commented Jun 22, 2022

I have opened the issue to fix the lint https://bugzilla.redhat.com/show_bug.cgi?id=2100137

@mnecas mnecas force-pushed the enable-ansible-lint branch 2 times, most recently from 9965a8f to ace2fca Compare June 22, 2022 15:25
@dangel101 dangel101 mentioned this pull request Sep 15, 2022
Closed
dangel101 added a commit to dangel101/ovirt-engine that referenced this pull request Sep 15, 2022
@dangel101
ansible lint fixes
c825bc3 
Including fixes according to ansible lint rules for engine roles and adding
ansible-lint tests to CI (oVirt#484)

Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=2100137
@dangel101 dangel101 mentioned this pull request Sep 28, 2022
Merged
dangel101 added a commit to dangel101/ovirt-engine that referenced this pull request Sep 28, 2022
@dangel101
adding ansible-lint tests to CI (oVirt#484)
6b8a262
dangel101 added a commit to dangel101/ovirt-engine that referenced this pull request Sep 29, 2022
@dangel101
adding ansible-lint tests to CI (oVirt#484)
c50a679
dangel101 added a commit to dangel101/ovirt-engine that referenced this pull request Oct 3, 2022
@dangel101
adding ansible-lint tests to CI (oVirt#484)
47ca13f
dangel101 added a commit to dangel101/ovirt-engine that referenced this pull request Oct 6, 2022
@dangel101
adding ansible-lint tests to CI (oVirt#484)
732855c
@mnecas
Copy link
Member Author

mnecas commented Oct 6, 2022

Moved to #684

@mnecas mnecas closed this Oct 6, 2022
mwperina pushed a commit to dangel101/ovirt-engine that referenced this pull request Oct 7, 2022
@dangel101 @mwperina
adding ansible-lint tests to CI (oVirt#484)
d9d0fbf
mwperina pushed a commit to dangel101/ovirt-engine that referenced this pull request Oct 7, 2022
@dangel101 @mwperina
adding ansible-lint tests to CI (oVirt#484)
fcf3b2d
mwperina pushed a commit to dangel101/ovirt-engine that referenced this pull request Oct 7, 2022
@dangel101 @mwperina
adding ansible-lint tests to CI (oVirt#484)
7d3601c
mwperina pushed a commit to dangel101/ovirt-engine that referenced this pull request Oct 10, 2022
@dangel101 @mwperina
adding ansible-lint tests to CI (oVirt#484)
5d32e64
mwperina pushed a commit to dangel101/ovirt-engine that referenced this pull request Oct 10, 2022
@dangel101 @mwperina
adding ansible-lint tests to CI (oVirt#484)
c78d77f
mwperina pushed a commit to dangel101/ovirt-engine that referenced this pull request Oct 10, 2022
@dangel101 @mwperina
adding ansible-lint tests to CI (oVirt#484)
cc0a26f
mwperina pushed a commit to dangel101/ovirt-engine that referenced this pull request Oct 10, 2022
@dangel101 @mwperina
adding ansible-lint tests to CI (oVirt#484)
6b20ea8
@mwperina mwperina mentioned this pull request Oct 13, 2022
Closed
dangel101 added a commit to dangel101/ovirt-engine that referenced this pull request Oct 18, 2022
@dangel101
adding ansible-lint tests to CI (oVirt#484)
3c6f246
dangel101 added a commit to dangel101/ovirt-engine that referenced this pull request Oct 19, 2022
@dangel101
adding ansible-lint tests to CI (oVirt#484)
25e3f5c
dangel101 added a commit to dangel101/ovirt-engine that referenced this pull request Oct 19, 2022
@dangel101
adding ansible-lint tests to CI (oVirt#484)
2d99667
dangel101 added a commit to dangel101/ovirt-engine that referenced this pull request Oct 19, 2022
@dangel101
adding ansible-lint tests to CI (oVirt#484)
f159911
dangel101 added a commit to dangel101/ovirt-engine that referenced this pull request Oct 25, 2022
@dangel101
adding ansible-lint tests to CI (oVirt#484)
02d9f6b
dangel101 added a commit to dangel101/ovirt-engine that referenced this pull request Oct 26, 2022
@dangel101
adding ansible-lint tests to CI (oVirt#484)
fc15f6b
mwperina pushed a commit that referenced this pull request Oct 27, 2022
@dangel101 @mwperina
adding ansible-lint tests to CI (#484)
6b6bf1f
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mwperina mwperina mwperina left review comments

@sandrobonazzola sandrobonazzola sandrobonazzola approved these changes

@ahadas ahadas Awaiting requested review from ahadas ahadas is a code owner

@michalskrivanek michalskrivanek Awaiting requested review from michalskrivanek michalskrivanek is a code owner

@didib didib Awaiting requested review from didib didib is a code owner

@dangel101 dangel101 Awaiting requested review from dangel101

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@mnecas @sandrobonazzola @mwperina