webadmin: Add IDs to main events view table #612
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/ost |
|
Can you please provide a description? |
ljelinkova
force-pushed
the
events-table-2
branch
from
10ea4ae
to
fccf485
Compare
|
/ost |
2 similar comments
|
/ost |
|
/ost |
The events table used default ids. To allow testing of the cluster upgrade, where the events table shows the progress of the upgrade, it is more convenient to use specific ids. This patch adds ViewIdHandler to MainEventView that generates ids with MainEventView_ prefix.
ljelinkova
force-pushed
the
events-table-2
branch
from
fccf485
to
42e534a
Compare
|
/ost |
smelamud
approved these changes
Sep 8, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.