webadmin: remove the validation for a new template #621
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When we create a new template, it is not possible to change almost any value defined in the original VM. Therefore, it does not make sense to validate on the UI, because the user cannot do anything if the validation fails. Moreover, if the validation fails, there is no way to display the results to the user - the dialog just stays open with no message displayed. When we remove the validation on the UI, we will depend on the backend validations and if something fails, the backend error messages would be displayed to the user. Note that the exception from this is the check for the duplicate name, that is performed separately and will be preserved as frontend check. In this case, the name field is marked as not valid with proper error message.
|
/ost |
|
lgtm |
smelamud
approved these changes
Aug 30, 2022
ljelinkova
added a commit
to ljelinkova/ovirt-engine
that referenced
this pull request
Sep 23, 2022
In PR [1], the validation of a new template was removed from the UI in assumption that the backend can validate the template properly. However, the backend does not contain validation for the name and if the name is not provided, it fails on inserting null to a not null database column. This patch adds the name validation back to the fronted. 1: oVirt#621
michalskrivanek
pushed a commit
that referenced
this pull request
Sep 23, 2022
In PR [1], the validation of a new template was removed from the UI in assumption that the backend can validate the template properly. However, the backend does not contain validation for the name and if the name is not provided, it fails on inserting null to a not null database column. This patch adds the name validation back to the fronted. 1: #621
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When we create a new template, it is not possible to change almost any value defined in the original VM.
Therefore, it does not make sense to validate on the UI, because the user cannot do anything if the validation fails.
Moreover, if the validation fails, there is no way to display the results to the user - the dialog just stays open with no message displayed.
When we remove the validation on the UI, we will depend on the backend validations and if something fails, the backend error messages would be displayed to the user.
Note that the exception from this is the check for the duplicate name, that is performed separately and will be preserved as frontend check. In this case, the name field is marked as not valid with proper error message.