Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

webadmin: remove the validation for a new template #621

Merged
merged 1 commit into from
Aug 30, 2022

Commits on Aug 30, 2022

  1. webadmin: remove the validation for a new template

    When we create a new template, it is not possible
    to change almost any value defined in the original VM.
    Therefore, it does not make sense to validate on the UI,
    because the user cannot do anything if the validation fails.
    Moreover, if the validation fails, there is no way to display
    the results to the user - the dialog just stays open
    with no message displayed.
    
    When we remove the validation on the UI, we will depend on the
    backend validations and if something fails, the backend error
    messages would be displayed to the user.
    
    Note that the exception from this is the check for the duplicate name,
    that is performed separately and will be preserved as frontend
    check. In this case, the name field is marked as not valid with
    proper error message.
    ljelinkova committed Aug 30, 2022
    Configuration menu
    Copy the full SHA
    f0f26c3 View commit details
    Browse the repository at this point in the history