Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make register-vm a sync operation #655

Merged
merged 1 commit into from
Sep 22, 2022
Merged

Conversation

ahadas
Copy link
Member

@ahadas ahadas commented Sep 14, 2022

In 38d5120 we've changed add VM from configuration to
be a blocking/sync operation. Here we do something similar for
register-vm, setting it to blocking/sync by default, for the
same reason - this operation doesn't involve copying the disks,
only add-lease is asynchronous and it is a relatively short
operation, so the caller won't wait much and at the end of the
call the VM is ready to be used.

This is particularly important for disaster recovery as we try
to start highly available VMs right after registering them. It
might have been better to change the disaster recovery scripts
to specify async=false, but that would require more efforts.

That change revealed an issue with the tests of ExportVmTemplate
since it is monitored by polling the job but tested as if it
was monitored by polling the VDSM tasks. Therefore the API
tests of ExportVmTemplate are also changed here.

Bug-Url: https://bugzilla.redhat.com/1968433
Signed-off-by: Arik Hadas ahadas@redhat.com

@ahadas
Copy link
Member Author

ahadas commented Sep 18, 2022

/ost

@ahadas
Copy link
Member Author

ahadas commented Sep 19, 2022

OST passed locally
@mwperina @oliel could you review it before 4.5.3's code freeze?

Copy link
Contributor

@oliel oliel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just one question ^

In 38d5120 we've changed add VM from configuration to
be a blocking/sync operation. Here we do something similar for
register-vm, setting it to blocking/sync by default, for the
same reason - this operation doesn't involve copying the disks,
only add-lease is asynchronous and it is a relatively short
operation, so the caller won't wait much and at the end of the
call the VM is ready to be used.

This is particularly important for disaster recovery as we try
to start highly available VMs right after registering them. It
might have been better to change the disaster recovery scripts
to specify async=false, but that would require more efforts.

That change revealed an issue with the tests of ExportVmTemplate
since it is monitored by polling the job but tested as if it
was monitored by polling the VDSM tasks. Therefore the API
tests of ExportVmTemplate are also changed here.

Bug-Url: https://bugzilla.redhat.com/1968433
Signed-off-by: Arik Hadas <ahadas@redhat.com>
@ahadas
Copy link
Member Author

ahadas commented Sep 21, 2022

/ost

@ahadas
Copy link
Member Author

ahadas commented Sep 22, 2022

getting this in since we approach the code freeze of ovirt 4.5.3 and I believe @oliel 's comment has been addressed

@ahadas ahadas merged commit a95002c into oVirt:master Sep 22, 2022
@ahadas ahadas deleted the bug_1968433 branch October 22, 2022 19:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants