Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make register-vm a sync operation #655

Merged
merged 1 commit into from
Sep 22, 2022
Merged

Commits on Sep 21, 2022

  1. core: make register-vm a sync operation

    In 38d5120 we've changed add VM from configuration to
    be a blocking/sync operation. Here we do something similar for
    register-vm, setting it to blocking/sync by default, for the
    same reason - this operation doesn't involve copying the disks,
    only add-lease is asynchronous and it is a relatively short
    operation, so the caller won't wait much and at the end of the
    call the VM is ready to be used.
    
    This is particularly important for disaster recovery as we try
    to start highly available VMs right after registering them. It
    might have been better to change the disaster recovery scripts
    to specify async=false, but that would require more efforts.
    
    That change revealed an issue with the tests of ExportVmTemplate
    since it is monitored by polling the job but tested as if it
    was monitored by polling the VDSM tasks. Therefore the API
    tests of ExportVmTemplate are also changed here.
    
    Bug-Url: https://bugzilla.redhat.com/1968433
    Signed-off-by: Arik Hadas <ahadas@redhat.com>
    ahadas committed Sep 21, 2022
    Configuration menu
    Copy the full SHA
    752f972 View commit details
    Browse the repository at this point in the history