Backport: Add missing copies of TPM parameters #724
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
mwperina
commented
Nov 2, 2022
mwperina
commented
- core: Add missing items in VmManagementParametersBase copy constructor
- frontend: Add TPM parameter when cloning a VM from a snapshot
- core: Update TPM device in parameters
When cloning a VM from a snapshot, isTpmEnabled parameter is not set in VmSnapshotListModel, resulting in a loss of the TPM device and an error if the TPM device is mandatory, i.e. for VMs with newer Windows versions as the guest OS. This patch fixes the omission and adds the corresponding parameter. Bug-Url: oVirt#702 Bug-Url: https://bugzilla.redhat.com/2136180
TPM device is not updated in VmDeviceUtils.updateVmDevicesInParameters. This results in omitting the TPM device at least when exporting a VM to a data domain and an error when the TPM device is mandatory, i.e. for VMs with a modern Windows guest OS. This patch fixes the omission and sets the corresponding parameter. Bug-Url: oVirt#702
mwperina
requested review from
sgratch,
ljelinkova,
ahadas,
bennyz,
emesika,
michalskrivanek,
oliel,
smelamud and
didib
as code owners
mz-pdm
approved these changes
Nov 2, 2022
ljelinkova
approved these changes
Nov 2, 2022
ahadas
approved these changes
Nov 2, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.