Allow setting all DisplayType's via API #857
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dupondje
force-pushed
the
update_displaytypes
branch
4 times, most recently
from
fd55595
to
8a4edb1
Compare
|
This needs a bump of the api-model. Tested and seems to work :) |
sandrobonazzola
requested review from
BrooklynDewolf
and removed request for
oliel
This change allows to set the DisplayType via the API. And also prefers VNC over SPICE as SPICE is deprecated. Signed-off-by: Jean-Louis Dupond <jean-louis@dupond.be>
sandrobonazzola
force-pushed
the
update_displaytypes
branch
from
8a4edb1
to
9dbe9b1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After updating the api model, we can accept all the known DisplayType's via the API.
Needs oVirt/ovirt-engine-api-model#102