Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

basic: Use Selenium grid from storage VM #76

Merged
merged 1 commit into from
Apr 20, 2022
Merged

basic: Use Selenium grid from storage VM #76

merged 1 commit into from
Apr 20, 2022

Conversation

tinez
Copy link
Member

@tinez tinez commented Mar 21, 2022

This patch gets rid of all the code that used podman to run Selenium
grid. Instead, we're using the one that exists in 'storage-base' VM.

Signed-off-by: Marcin Sobczyk msobczyk@redhat.com

@tinez tinez marked this pull request as draft March 21, 2022 14:58
@tinez tinez force-pushed the selenium-vm branch 3 times, most recently from 74b72e7 to f24d3e1 Compare April 8, 2022 09:32
@tinez tinez marked this pull request as ready for review April 8, 2022 09:33
@tinez
Copy link
Member Author

tinez commented Apr 8, 2022

/ost

@tinez tinez force-pushed the selenium-vm branch 4 times, most recently from 60dc05b to 3e629db Compare April 8, 2022 10:49
@tinez
Copy link
Member Author

tinez commented Apr 8, 2022

/ost

@tinez
Copy link
Member Author

tinez commented Apr 8, 2022

/ost

@tinez
Copy link
Member Author

tinez commented Apr 14, 2022

/ost

@tinez tinez force-pushed the selenium-vm branch 2 times, most recently from e184438 to f3e6dab Compare April 14, 2022 12:37
@tinez
Copy link
Member Author

tinez commented Apr 14, 2022

/ost

@tinez
Copy link
Member Author

tinez commented Apr 19, 2022

/ost

ost_utils/pytest/fixtures/selenium.py Outdated Show resolved Hide resolved
common/init-configs/1_engine_2_hosts.json Show resolved Hide resolved
@tinez
Copy link
Member Author

tinez commented Apr 20, 2022

/ost

Copy link
Contributor

@ljelinkova ljelinkova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just one question.

This patch gets rid of all the code that used podman to run Selenium
grid. Instead, we're using the one that exists in 'storage-base' VM.

Signed-off-by: Marcin Sobczyk <msobczyk@redhat.com>
Change-Id: Ib37f3d4267a96851fe9b42a41d9ba3e711408589
@tinez
Copy link
Member Author

tinez commented Apr 20, 2022

/ost

@tinez tinez merged commit 2bf8ce2 into master Apr 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants