Add integration with vnc console #854

kozloffsky · 2018-11-08T18:07:14Z

Add integration with VncConsole

fixes #490

ovirt-infra · 2018-11-08T18:07:15Z

Hello contributor, thanks for submitting a PR for this project!

I am the bot who triggers "standard-CI" builds for this project.
As a security measure, I will not run automated tests on PRs that are not from white-listed contributors.

In order to allow automated tests to run, please ask one of the project maintainers to review the code and then do one of the following:

Type ci test please on this PR to trigger automated tests for it.
Type ci add to whitelist on this PR to trigger automated tests for it and also add you to the contributor white-list so that your future PRs will be tested automatically.
If you are planning to contribute to more than one project, maybe it's better to ask them to add you to the project organization, so you'll be able to run tests for all the organization's projects.

gregsheremeta · 2018-11-08T20:13:17Z

ci add to whitelist

gregsheremeta · 2018-11-08T20:15:58Z

config/paths.js

@@ -35,4 +35,5 @@ module.exports = {
  appNodeModules: resolveApp('node_modules'),
  ownNodeModules: resolveApp('node_modules'),
  nodePaths: nodePaths,
+  novmc: resolveApp('node_modules/@novnc/novnc')


change to:

novnc: resolveApp('node_modules/@novnc/novnc')

('n' vs 'm')

Replace, please, 'm' with 'n'

bond95 · 2018-11-12T12:42:40Z

config/paths.js

@@ -35,4 +35,5 @@ module.exports = {
  appNodeModules: resolveApp('node_modules'),
  ownNodeModules: resolveApp('node_modules'),
  nodePaths: nodePaths,
+  novmc: resolveApp('node_modules/@novnc/novnc')


~~Is this module need? Cause I didn't see in https://github.com/patternfly/patternfly-react/tree/master/packages/patternfly-3/react-console @novnc/novnc requirement.~~

Ok, I found it, but it's already in module dependencies, thus I little bit change question. Is this module need to install explicitly?

@bond95 This module does not have in dist regular js code so it needs to me babelized.

gregsheremeta · 2018-11-14T20:11:17Z

src/App.js

@@ -51,7 +51,9 @@ const App = ({ history, config, appReady }) => {
  return (
    <ConnectedRouter history={history}>
      <div id='app-container'>
-        <VncConsole host='localhost' port='3333' />
+        <VncConsole encrypt='true'
+          path='eyJzYWx0IjoicDNXeWRiNUswWm89IiwiZGF0YSI6IiU3QiUyMnBvcnQlMjIlM0ElMjI1OTAzJTIyJTJDJTIyaG9zdCUyMiUzQSUyMjEwLjM3LjE2MC41MSUyMiUyQyUyMnNzbF90YXJnZXQlMjIlM0FmYWxzZSU3RCIsInNpZ25hdHVyZSI6IjNaWHgzS0VpL1gyMEVpNXVHekpueENxbTRIcUlHV051Wk5KeUYwa29WbHBOUXRiWVFWeHUrY0VuSHNlM29YN1AwVzBlTWhZVTU5NlFDK01HNldHT0NPYUJURzU0TFNpOEtqL0t6dW9WODN5MVZVM0dUbU5CNDlCdE1pQ3VqYm5qaHNlcTdDdGJ2S0tsV3hZRGhPSkRQSEhHbkpSR3JGNzluSXNsU2JTM2hNc2xyUUJqQ0crMXN5bkI1UklWODJJSTA0TElvVjAxYTMwRi95S3hoZmFJRFhuTEc3aVVFNWV5T09RZWFPbjZXWjFRMlN6ZWtUbFpOZEhndlhpYkNNbjN6VXVGZ2RLWWpUNWhKZmdRa3VNNGFaQTk3Q3U2bDBRY0JZUitGbDZvYm5pTGJFMWNMbVR3ekR4Qm12K2s3L2hzNGNvc2Q1eUJDOHkxd3VpTzMwWlRFZz09IiwiZGlnZXN0Ijoic2hhMSIsImNlcnRpZmljYXRlIjoiLS0tLS1CRUdJTiBDRVJUSUZJQ0FURS0tLS0tXG5NSUlGQ0RDQ0EvQ2dBd0lCQWdJQ0VBRXdEUVlKS29aSWh2Y05BUUVMQlFBd1p6RUxNQWtHQTFVRUJoTUNWVk14SkRBaUJnTlZCQW9NXHJcbkczSm9aWFl1YkdGaUxtVnVaeTVpY25FdWNtVmthR0YwTG1OdmJURXlNREFHQTFVRUF3d3BZbkp4TFdSbGRpNXlhR1YyTG14aFlpNWxcclxuYm1jdVluSnhMbkpsWkdoaGRDNWpiMjB1TkRjeE5qZ3dIaGNOTVRnd09UQTJNRGcxTmpVeVdoY05Nak13T0RFeU1EZzFOalV5V2pCaFxyXG5NUXN3Q1FZRFZRUUdFd0pWVXpFa01DSUdBMVVFQ2d3YmNtaGxkaTVzWVdJdVpXNW5MbUp5Y1M1eVpXUm9ZWFF1WTI5dE1Td3dLZ1lEXHJcblZRUUREQ05pY25FdFpHVjJMbkpvWlhZdWJHRmlMbVZ1Wnk1aWNuRXVjbVZrYUdGMExtTnZiVENDQVNJd0RRWUpLb1pJaHZjTkFRRUJcclxuQlFBRGdnRVBBRENDQVFvQ2dnRUJBT0ZFZFRUUGxmTzdUZGwwRlY4TGFWMHRTQjJqcUVmeVFmd0k1clEyTkR1VElERHVOOFh2R0xIZ1xyXG4rV2tWQnJ6aDFicTJMcW9QcUJUWkJaejhXZCtoU2FKU0MvRGZ6RWlXbVhtbTUxdWd4RFo3N0tVODV6dndoU2x5Z1hocnEzMERSSVdKXHJcbk4rdEpQUDRXSXJyUjBKQTFkbFZaSThHb1liT2hVcTEwNDBBVHJDU0tPQWdiTXBSR3F4SkhhejNnZ3FaUzliYyttajV2Y2tDbzh3eHhcclxudjllNUJpU1RZQ1dURUU4T3JvTHdndjZjZVp4YU9RQ2NPRjNSOXJhY0QvRlhmSDFYellvTWNWbUhnakNrZVlZdjBGblMxRHNWcjBOQlxyXG5sb0Z1eTBTa1FGajhxZnludjFmS0lIL0VNQTVYNGNOalpDNmNTVUpxWENFNjd4ZUMwU2JPK1pmTHkxRUNBd0VBQWFPQ0FjSXdnZ0crXHJcbk1CMEdBMVVkRGdRV0JCUTJzajc0d3RGaUdmTDVjZytmdTBEczIrcEg3ekNCbWdZSUt3WUJCUVVIQVFFRWdZMHdnWW93Z1ljR0NDc0dcclxuQVFVRkJ6QUNobnRvZEhSd09pOHZZbkp4TFdSbGRpNXlhR1YyTG14aFlpNWxibWN1WW5KeExuSmxaR2hoZEM1amIyMDZPREF2YjNacFxyXG5jblF0Wlc1bmFXNWxMM05sY25acFkyVnpMM0JyYVMxeVpYTnZkWEpqWlQ5eVpYTnZkWEpqWlQxallTMWpaWEowYVdacFkyRjBaU1ptXHJcbmIzSnRZWFE5V0RVd09TMVFSVTB0UTBFd2daSUdBMVVkSXdTQmlqQ0JoNEFVVmllZnFjK2djSFVBQ2dDRThsVVFRQUxTTldHaGE2UnBcclxuTUdjeEN6QUpCZ05WQkFZVEFsVlRNU1F3SWdZRFZRUUtEQnR5YUdWMkxteGhZaTVsYm1jdVluSnhMbkpsWkdoaGRDNWpiMjB4TWpBd1xyXG5CZ05WQkFNTUtXSnljUzFrWlhZdWNtaGxkaTVzWVdJdVpXNW5MbUp5Y1M1eVpXUm9ZWFF1WTI5dExqUTNNVFk0Z2dJUUFEQUpCZ05WXHJcbkhSTUVBakFBTUE0R0ExVWREd0VCL3dRRUF3SUZvREFnQmdOVkhTVUJBZjhFRmpBVUJnZ3JCZ0VGQlFjREFRWUlLd1lCQlFVSEF3SXdcclxuTGdZRFZSMFJCQ2N3SllJalluSnhMV1JsZGk1eWFHVjJMbXhoWWk1bGJtY3VZbkp4TG5KbFpHaGhkQzVqYjIwd0RRWUpLb1pJaHZjTlxyXG5BUUVMQlFBRGdnRUJBRWI1V1NvU3BPd1JUZjdVNnlPLzdwNUIvT3RiZHQrdGtPei9WSFBhRm54YlcwTUMrR3hGdEI0dVBQNVNwVHNQXHJcblZkWDJ0aVRVeXlKU3RMbXRMVWxlTHYrM0ZVbW9NcDV2eis4UnU0REE4QzNzdlhrYkNTZS9Qd2JOOEFyYlN2eXI5aUMveUpmN25OQ2Rcclxuckh1bzEzWnpZNDEvdTlUSHhiSW5pNHZPT00xTGw0WDBwOVRSTko1bzBhSTl5djBoR2NTV21HT0QyUi9pNWk1SkJFMVFFaVVrVlJWUVxyXG5vS3l5QXVveExtNkQ4bkJKMWRrUzhHVUtuM3J4blFFUGNZd2I0dGdaS3V6bG03RkdMOWI3ZEw2ZWpyNStmTEdLY3ZYWkJXcmF1dXQwXHJcbkV0WDQ2ODI1elorZHg1NXpPbm9Xa2cvSzBDQkpjM0prQ29ES0toVlVZQTZTRGtZbGF1Zz1cclxuLS0tLS1FTkQgQ0VSVElGSUNBVEUtLS0tLVxuIiwic2lnbmVkRmllbGRzIjoic2FsdCxkYXRhLGRpZ2VzdCx2YWxpZEZyb20sdmFsaWRUbyIsInZhbGlkRnJvbSI6IjIwMTgxMTEyMTQyOTI4IiwidmFsaWRUbyI6IjIwMTgxMTEyMTQzMTI4In0'


what does path do and what is this giant string?

gregsheremeta · 2018-11-14T20:11:58Z

src/App.js

-        <VncConsole host='localhost' port='3333' />
+        <VncConsole encrypt='true'
+          path='eyJzYWx0IjoicDNXeWRiNUswWm89IiwiZGF0YSI6IiU3QiUyMnBvcnQlMjIlM0ElMjI1OTAzJTIyJTJDJTIyaG9zdCUyMiUzQSUyMjEwLjM3LjE2MC41MSUyMiUyQyUyMnNzbF90YXJnZXQlMjIlM0FmYWxzZSU3RCIsInNpZ25hdHVyZSI6IjNaWHgzS0VpL1gyMEVpNXVHekpueENxbTRIcUlHV051Wk5KeUYwa29WbHBOUXRiWVFWeHUrY0VuSHNlM29YN1AwVzBlTWhZVTU5NlFDK01HNldHT0NPYUJURzU0TFNpOEtqL0t6dW9WODN5MVZVM0dUbU5CNDlCdE1pQ3VqYm5qaHNlcTdDdGJ2S0tsV3hZRGhPSkRQSEhHbkpSR3JGNzluSXNsU2JTM2hNc2xyUUJqQ0crMXN5bkI1UklWODJJSTA0TElvVjAxYTMwRi95S3hoZmFJRFhuTEc3aVVFNWV5T09RZWFPbjZXWjFRMlN6ZWtUbFpOZEhndlhpYkNNbjN6VXVGZ2RLWWpUNWhKZmdRa3VNNGFaQTk3Q3U2bDBRY0JZUitGbDZvYm5pTGJFMWNMbVR3ekR4Qm12K2s3L2hzNGNvc2Q1eUJDOHkxd3VpTzMwWlRFZz09IiwiZGlnZXN0Ijoic2hhMSIsImNlcnRpZmljYXRlIjoiLS0tLS1CRUdJTiBDRVJUSUZJQ0FURS0tLS0tXG5NSUlGQ0RDQ0EvQ2dBd0lCQWdJQ0VBRXdEUVlKS29aSWh2Y05BUUVMQlFBd1p6RUxNQWtHQTFVRUJoTUNWVk14SkRBaUJnTlZCQW9NXHJcbkczSm9aWFl1YkdGaUxtVnVaeTVpY25FdWNtVmthR0YwTG1OdmJURXlNREFHQTFVRUF3d3BZbkp4TFdSbGRpNXlhR1YyTG14aFlpNWxcclxuYm1jdVluSnhMbkpsWkdoaGRDNWpiMjB1TkRjeE5qZ3dIaGNOTVRnd09UQTJNRGcxTmpVeVdoY05Nak13T0RFeU1EZzFOalV5V2pCaFxyXG5NUXN3Q1FZRFZRUUdFd0pWVXpFa01DSUdBMVVFQ2d3YmNtaGxkaTVzWVdJdVpXNW5MbUp5Y1M1eVpXUm9ZWFF1WTI5dE1Td3dLZ1lEXHJcblZRUUREQ05pY25FdFpHVjJMbkpvWlhZdWJHRmlMbVZ1Wnk1aWNuRXVjbVZrYUdGMExtTnZiVENDQVNJd0RRWUpLb1pJaHZjTkFRRUJcclxuQlFBRGdnRVBBRENDQVFvQ2dnRUJBT0ZFZFRUUGxmTzdUZGwwRlY4TGFWMHRTQjJqcUVmeVFmd0k1clEyTkR1VElERHVOOFh2R0xIZ1xyXG4rV2tWQnJ6aDFicTJMcW9QcUJUWkJaejhXZCtoU2FKU0MvRGZ6RWlXbVhtbTUxdWd4RFo3N0tVODV6dndoU2x5Z1hocnEzMERSSVdKXHJcbk4rdEpQUDRXSXJyUjBKQTFkbFZaSThHb1liT2hVcTEwNDBBVHJDU0tPQWdiTXBSR3F4SkhhejNnZ3FaUzliYyttajV2Y2tDbzh3eHhcclxudjllNUJpU1RZQ1dURUU4T3JvTHdndjZjZVp4YU9RQ2NPRjNSOXJhY0QvRlhmSDFYellvTWNWbUhnakNrZVlZdjBGblMxRHNWcjBOQlxyXG5sb0Z1eTBTa1FGajhxZnludjFmS0lIL0VNQTVYNGNOalpDNmNTVUpxWENFNjd4ZUMwU2JPK1pmTHkxRUNBd0VBQWFPQ0FjSXdnZ0crXHJcbk1CMEdBMVVkRGdRV0JCUTJzajc0d3RGaUdmTDVjZytmdTBEczIrcEg3ekNCbWdZSUt3WUJCUVVIQVFFRWdZMHdnWW93Z1ljR0NDc0dcclxuQVFVRkJ6QUNobnRvZEhSd09pOHZZbkp4TFdSbGRpNXlhR1YyTG14aFlpNWxibWN1WW5KeExuSmxaR2hoZEM1amIyMDZPREF2YjNacFxyXG5jblF0Wlc1bmFXNWxMM05sY25acFkyVnpMM0JyYVMxeVpYTnZkWEpqWlQ5eVpYTnZkWEpqWlQxallTMWpaWEowYVdacFkyRjBaU1ptXHJcbmIzSnRZWFE5V0RVd09TMVFSVTB0UTBFd2daSUdBMVVkSXdTQmlqQ0JoNEFVVmllZnFjK2djSFVBQ2dDRThsVVFRQUxTTldHaGE2UnBcclxuTUdjeEN6QUpCZ05WQkFZVEFsVlRNU1F3SWdZRFZRUUtEQnR5YUdWMkxteGhZaTVsYm1jdVluSnhMbkpsWkdoaGRDNWpiMjB4TWpBd1xyXG5CZ05WQkFNTUtXSnljUzFrWlhZdWNtaGxkaTVzWVdJdVpXNW5MbUp5Y1M1eVpXUm9ZWFF1WTI5dExqUTNNVFk0Z2dJUUFEQUpCZ05WXHJcbkhSTUVBakFBTUE0R0ExVWREd0VCL3dRRUF3SUZvREFnQmdOVkhTVUJBZjhFRmpBVUJnZ3JCZ0VGQlFjREFRWUlLd1lCQlFVSEF3SXdcclxuTGdZRFZSMFJCQ2N3SllJalluSnhMV1JsZGk1eWFHVjJMbXhoWWk1bGJtY3VZbkp4TG5KbFpHaGhkQzVqYjIwd0RRWUpLb1pJaHZjTlxyXG5BUUVMQlFBRGdnRUJBRWI1V1NvU3BPd1JUZjdVNnlPLzdwNUIvT3RiZHQrdGtPei9WSFBhRm54YlcwTUMrR3hGdEI0dVBQNVNwVHNQXHJcblZkWDJ0aVRVeXlKU3RMbXRMVWxlTHYrM0ZVbW9NcDV2eis4UnU0REE4QzNzdlhrYkNTZS9Qd2JOOEFyYlN2eXI5aUMveUpmN25OQ2Rcclxuckh1bzEzWnpZNDEvdTlUSHhiSW5pNHZPT00xTGw0WDBwOVRSTko1bzBhSTl5djBoR2NTV21HT0QyUi9pNWk1SkJFMVFFaVVrVlJWUVxyXG5vS3l5QXVveExtNkQ4bkJKMWRrUzhHVUtuM3J4blFFUGNZd2I0dGdaS3V6bG03RkdMOWI3ZEw2ZWpyNStmTEdLY3ZYWkJXcmF1dXQwXHJcbkV0WDQ2ODI1elorZHg1NXpPbm9Xa2cvSzBDQkpjM0prQ29ES0toVlVZQTZTRGtZbGF1Zz1cclxuLS0tLS1FTkQgQ0VSVElGSUNBVEUtLS0tLVxuIiwic2lnbmVkRmllbGRzIjoic2FsdCxkYXRhLGRpZ2VzdCx2YWxpZEZyb20sdmFsaWRUbyIsInZhbGlkRnJvbSI6IjIwMTgxMTEyMTQyOTI4IiwidmFsaWRUbyI6IjIwMTgxMTEyMTQzMTI4In0'
+          host='brq-dev.rhev.lab.eng.brq.redhat.com' port='6100' />


these should be variables

gregsheremeta · 2018-11-14T20:12:38Z

src/components/VmActions/ConsoleConfirmationModal.js

@@ -78,6 +78,6 @@ export default connect(
  (dispatch, { vm, consoleId }) => ({
    onCheckConsoleSessionInUse: ({ usbFilter, userId }) => dispatch(checkConsoleInUse({ vmId: vm.get('id'), usbFilter, userId })),
    onConsoleSessionConfirmaClose: () => dispatch(setConsoleInUse({ vmId: vm.get('id'), consoleInUse: null })),
-    onDownloadConsole: ({ usbFilter }) => dispatch(downloadConsole({ vmId: vm.get('id'), usbFilter, consoleId })),
+    onDownloadConsole: ({ usbFilter }) => dispatch(openConsole({ vmId: vm.get('id'), usbFilter: usbFilter, consoleId: consoleId })),


may want to rename onDownloadConsole to onOpenConsole

bond95 · 2018-11-15T13:38:56Z

src/App.js

@@ -51,7 +51,9 @@ const App = ({ history, config, appReady }) => {
  return (
    <ConnectedRouter history={history}>
      <div id='app-container'>
-        <VncConsole host='localhost' port='3333' />
+        <VncConsole encrypt='true'


This must be a boolean not string, it means you can just write:

<VncConsole encrypt .... />

bond95 · 2018-11-15T14:03:59Z

src/App.js

-        <VncConsole host='localhost' port='3333' />
+        <VncConsole encrypt='true'
+          path='eyJzYWx0IjoicDNXeWRiNUswWm89IiwiZGF0YSI6IiU3QiUyMnBvcnQlMjIlM0ElMjI1OTAzJTIyJTJDJTIyaG9zdCUyMiUzQSUyMjEwLjM3LjE2MC41MSUyMiUyQyUyMnNzbF90YXJnZXQlMjIlM0FmYWxzZSU3RCIsInNpZ25hdHVyZSI6IjNaWHgzS0VpL1gyMEVpNXVHekpueENxbTRIcUlHV051Wk5KeUYwa29WbHBOUXRiWVFWeHUrY0VuSHNlM29YN1AwVzBlTWhZVTU5NlFDK01HNldHT0NPYUJURzU0TFNpOEtqL0t6dW9WODN5MVZVM0dUbU5CNDlCdE1pQ3VqYm5qaHNlcTdDdGJ2S0tsV3hZRGhPSkRQSEhHbkpSR3JGNzluSXNsU2JTM2hNc2xyUUJqQ0crMXN5bkI1UklWODJJSTA0TElvVjAxYTMwRi95S3hoZmFJRFhuTEc3aVVFNWV5T09RZWFPbjZXWjFRMlN6ZWtUbFpOZEhndlhpYkNNbjN6VXVGZ2RLWWpUNWhKZmdRa3VNNGFaQTk3Q3U2bDBRY0JZUitGbDZvYm5pTGJFMWNMbVR3ekR4Qm12K2s3L2hzNGNvc2Q1eUJDOHkxd3VpTzMwWlRFZz09IiwiZGlnZXN0Ijoic2hhMSIsImNlcnRpZmljYXRlIjoiLS0tLS1CRUdJTiBDRVJUSUZJQ0FURS0tLS0tXG5NSUlGQ0RDQ0EvQ2dBd0lCQWdJQ0VBRXdEUVlKS29aSWh2Y05BUUVMQlFBd1p6RUxNQWtHQTFVRUJoTUNWVk14SkRBaUJnTlZCQW9NXHJcbkczSm9aWFl1YkdGaUxtVnVaeTVpY25FdWNtVmthR0YwTG1OdmJURXlNREFHQTFVRUF3d3BZbkp4TFdSbGRpNXlhR1YyTG14aFlpNWxcclxuYm1jdVluSnhMbkpsWkdoaGRDNWpiMjB1TkRjeE5qZ3dIaGNOTVRnd09UQTJNRGcxTmpVeVdoY05Nak13T0RFeU1EZzFOalV5V2pCaFxyXG5NUXN3Q1FZRFZRUUdFd0pWVXpFa01DSUdBMVVFQ2d3YmNtaGxkaTVzWVdJdVpXNW5MbUp5Y1M1eVpXUm9ZWFF1WTI5dE1Td3dLZ1lEXHJcblZRUUREQ05pY25FdFpHVjJMbkpvWlhZdWJHRmlMbVZ1Wnk1aWNuRXVjbVZrYUdGMExtTnZiVENDQVNJd0RRWUpLb1pJaHZjTkFRRUJcclxuQlFBRGdnRVBBRENDQVFvQ2dnRUJBT0ZFZFRUUGxmTzdUZGwwRlY4TGFWMHRTQjJqcUVmeVFmd0k1clEyTkR1VElERHVOOFh2R0xIZ1xyXG4rV2tWQnJ6aDFicTJMcW9QcUJUWkJaejhXZCtoU2FKU0MvRGZ6RWlXbVhtbTUxdWd4RFo3N0tVODV6dndoU2x5Z1hocnEzMERSSVdKXHJcbk4rdEpQUDRXSXJyUjBKQTFkbFZaSThHb1liT2hVcTEwNDBBVHJDU0tPQWdiTXBSR3F4SkhhejNnZ3FaUzliYyttajV2Y2tDbzh3eHhcclxudjllNUJpU1RZQ1dURUU4T3JvTHdndjZjZVp4YU9RQ2NPRjNSOXJhY0QvRlhmSDFYellvTWNWbUhnakNrZVlZdjBGblMxRHNWcjBOQlxyXG5sb0Z1eTBTa1FGajhxZnludjFmS0lIL0VNQTVYNGNOalpDNmNTVUpxWENFNjd4ZUMwU2JPK1pmTHkxRUNBd0VBQWFPQ0FjSXdnZ0crXHJcbk1CMEdBMVVkRGdRV0JCUTJzajc0d3RGaUdmTDVjZytmdTBEczIrcEg3ekNCbWdZSUt3WUJCUVVIQVFFRWdZMHdnWW93Z1ljR0NDc0dcclxuQVFVRkJ6QUNobnRvZEhSd09pOHZZbkp4TFdSbGRpNXlhR1YyTG14aFlpNWxibWN1WW5KeExuSmxaR2hoZEM1amIyMDZPREF2YjNacFxyXG5jblF0Wlc1bmFXNWxMM05sY25acFkyVnpMM0JyYVMxeVpYTnZkWEpqWlQ5eVpYTnZkWEpqWlQxallTMWpaWEowYVdacFkyRjBaU1ptXHJcbmIzSnRZWFE5V0RVd09TMVFSVTB0UTBFd2daSUdBMVVkSXdTQmlqQ0JoNEFVVmllZnFjK2djSFVBQ2dDRThsVVFRQUxTTldHaGE2UnBcclxuTUdjeEN6QUpCZ05WQkFZVEFsVlRNU1F3SWdZRFZRUUtEQnR5YUdWMkxteGhZaTVsYm1jdVluSnhMbkpsWkdoaGRDNWpiMjB4TWpBd1xyXG5CZ05WQkFNTUtXSnljUzFrWlhZdWNtaGxkaTVzWVdJdVpXNW5MbUp5Y1M1eVpXUm9ZWFF1WTI5dExqUTNNVFk0Z2dJUUFEQUpCZ05WXHJcbkhSTUVBakFBTUE0R0ExVWREd0VCL3dRRUF3SUZvREFnQmdOVkhTVUJBZjhFRmpBVUJnZ3JCZ0VGQlFjREFRWUlLd1lCQlFVSEF3SXdcclxuTGdZRFZSMFJCQ2N3SllJalluSnhMV1JsZGk1eWFHVjJMbXhoWWk1bGJtY3VZbkp4TG5KbFpHaGhkQzVqYjIwd0RRWUpLb1pJaHZjTlxyXG5BUUVMQlFBRGdnRUJBRWI1V1NvU3BPd1JUZjdVNnlPLzdwNUIvT3RiZHQrdGtPei9WSFBhRm54YlcwTUMrR3hGdEI0dVBQNVNwVHNQXHJcblZkWDJ0aVRVeXlKU3RMbXRMVWxlTHYrM0ZVbW9NcDV2eis4UnU0REE4QzNzdlhrYkNTZS9Qd2JOOEFyYlN2eXI5aUMveUpmN25OQ2Rcclxuckh1bzEzWnpZNDEvdTlUSHhiSW5pNHZPT00xTGw0WDBwOVRSTko1bzBhSTl5djBoR2NTV21HT0QyUi9pNWk1SkJFMVFFaVVrVlJWUVxyXG5vS3l5QXVveExtNkQ4bkJKMWRrUzhHVUtuM3J4blFFUGNZd2I0dGdaS3V6bG03RkdMOWI3ZEw2ZWpyNStmTEdLY3ZYWkJXcmF1dXQwXHJcbkV0WDQ2ODI1elorZHg1NXpPbm9Xa2cvSzBDQkpjM0prQ29ES0toVlVZQTZTRGtZbGF1Zz1cclxuLS0tLS1FTkQgQ0VSVElGSUNBVEUtLS0tLVxuIiwic2lnbmVkRmllbGRzIjoic2FsdCxkYXRhLGRpZ2VzdCx2YWxpZEZyb20sdmFsaWRUbyIsInZhbGlkRnJvbSI6IjIwMTgxMTEyMTQyOTI4IiwidmFsaWRUbyI6IjIwMTgxMTEyMTQzMTI4In0'
+          host='brq-dev.rhev.lab.eng.brq.redhat.com' port='6100' />


bond95 · 2018-11-15T14:57:38Z

src/saga/console/index.js

+    { type: 'INTRENAL_CONSOLE', payload: { vmId, consoleId } })
+  data.ticket = ticket
+  data.isSpice = isSpice
+  return data


I don't really understand why do you return here data?

bond95 · 2018-11-15T14:58:16Z

src/saga/console/index.js

+    }
+  }
+  let data = yield callExternalAction('consoleProxyTicket', Api.consoleProxyTicket,
+    { type: 'INTRENAL_CONSOLE', payload: { vmId, consoleId } })


Use constants, please.

bond95 · 2019-01-09T13:15:12Z

@kozloffsky rebase, please

gregsheremeta · 2019-01-09T13:27:41Z

@kozloffsky indeed, it's impossible to review unless it's rebased. I just released 1.5.0 (== master at this moment) so that's a nice clean place to start. Please schedule a video call with @bond95 for today if you need assistance.

gregsheremeta · 2019-01-09T13:28:07Z

@bond95 @kozloffsky rebase AND squash

bond95 · 2019-01-16T15:12:30Z

config/paths.js

@@ -35,4 +35,5 @@ module.exports = {
  appNodeModules: resolveApp('node_modules'),
  ownNodeModules: resolveApp('node_modules'),
  nodePaths: nodePaths,
+  novmc: resolveApp('node_modules/@novnc/novnc')


Replace, please, 'm' with 'n'

bond95 · 2019-01-16T15:12:43Z

config/webpack.config.dev.js

@@ -100,7 +100,7 @@ module.exports = {
      // Process JS with Babel.
      {
        test: /\.(js|jsx)$/,
-        include: paths.appSrc,
+        include: [paths.appSrc, paths.novmc],


bond95 · 2019-01-16T15:12:51Z

config/webpack.config.prod.js

@@ -96,7 +96,7 @@ module.exports = {
      // Process JS with Babel.
      {
        test: /\.(js|jsx)$/,
-        include: paths.appSrc,
+        include: [paths.appSrc, paths.novmc],


bond95 · 2019-01-16T15:13:55Z

src/actions/console.js

-  SET_CONSOLE_IN_USE,
-  SET_CONSOLE_LOGON,
-} from '_/constants'
+import { SET_CONSOLE_IN_USE, CHECK_CONSOLE_IN_USE, SET_CONSOLE_LOGON, SET_CONSOLE_TICKETS, DOWNLOAD_CONSOLE_VM } from '../constants'


I think it would be better to move each constant to separate line

bond95 · 2019-01-16T15:16:22Z

src/components/Pages/index.js

@@ -150,9 +152,76 @@ const VmCreatePageConnected = connect(
  })
 )(VmCreatePage)

+class VmConsoleSelector extends React.Component {


This component doesn't belong here, please, move it to separate file.

bond95 · 2019-01-16T15:24:58Z

src/ovirtapi/index.js

+    })
+  },
+
+  consoleTicket ({ vmId, consoleId }: {vmId: string, consoleId: string}): Promise<Object> {


Space after { and before }
{ vmId: string, consoleId: string }

bond95 · 2019-01-16T15:25:55Z

src/reducers/consoles.js

@@ -12,6 +12,11 @@ const consoles = actionReducer(initialState, {
  [SET_CONSOLE_LOGON] (state, { payload: { vmId, isLogon } }) {
    return state.setIn(['vms', vmId, 'isLogon'], isLogon)
  },
+  [SET_CONSOLE_TICKETS] (state, { payload: { vmId, proxyTicket, ticket } }) {
+    const tmpState = state.setIn(['vms', vmId, 'proxyTicket'], proxyTicket)


Why not to do chain of setIn?

bond95 · 2019-01-16T15:26:57Z

src/routes.js

+            path: '/vm/:id/console/:console_id',
+            title: (match) => match.params.console_id,
+            component: VmConsolePage,
+            closeable: true,


Add type of the page.

bond95 · 2019-01-16T15:28:30Z

src/saga/console/index.js

+  let ticket = yield callExternalAction('consoleTicket', Api.consoleTicket,
+    { type: 'INTRENAL_CONSOLE', payload: { vmId, consoleId } })
+  yield put(setConsoleTickets({ vmId, proxyTicket: data.proxy_ticket.value, ticket: ticket.ticket }))
+  logger.log(data)


If this log is unnecessary, please, remove it

bond95 · 2019-01-16T15:29:14Z

src/components/Pages/index.js

+    if (actionsCopy.length === 0) {
+      return null
+    }
+    return <SplitButton title='Spice Console' id={id}>


Translate, please.

gregsheremeta · 2019-01-18T09:13:48Z

@kozloffsky i see you rebased, but you didn't squash. It is not reviewable until you do. The commits are a mess and impossible to follow.

please squash before you do any more work on this. If you don't know what I'm talking about, please ping me or @bond95 .

type consoles, for others page begin config file download process. Also added console selector on page toolbar.

gregsheremeta · 2019-01-18T10:36:52Z

much better, thank you

refactorings

gregsheremeta · 2019-01-30T02:20:44Z

ci build please

gregsheremeta · 2019-01-30T02:35:01Z

[needs ovirt-engine-nodejs-modules update for react-console]

gregsheremeta · 2019-01-30T02:59:47Z

@kozloffsky I couldn't get the latest commits to run.

Production compile and installed rpm:

Dev compile:

gregsheremeta · 2019-02-05T13:02:53Z

closing, doesn't work

gregsheremeta reviewed Nov 8, 2018

View reviewed changes

bond95 reviewed Nov 12, 2018

View reviewed changes

michalskrivanek requested a review from mareklibra November 12, 2018 12:57

gregsheremeta reviewed Nov 14, 2018

View reviewed changes

bond95 suggested changes Nov 15, 2018

View reviewed changes

kozloffsky force-pushed the RHV-1720 branch 2 times, most recently from a748b92 to c628987 Compare January 14, 2019 11:40

bond95 suggested changes Jan 16, 2019

View reviewed changes

gregsheremeta mentioned this pull request Jan 17, 2019

Support web-based console connection #490

Closed

Added integration with novnc VNC console viewer as single page for VNC

e9151ea

type consoles, for others page begin config file download process. Also added console selector on page toolbar.

kozloffsky force-pushed the RHV-1720 branch from 5c80ee4 to e9151ea Compare January 18, 2019 10:31

Mykhailo Kozlovskyy added 2 commits January 29, 2019 12:20

Added console settings window, new messages and some toolbar

1022b33

refactorings

added check for novnc console is running in current window.

a9899a7

gregsheremeta removed the request for review from mareklibra January 30, 2019 03:00

gregsheremeta closed this Feb 5, 2019

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add integration with vnc console #854

Add integration with vnc console #854

kozloffsky commented Nov 8, 2018 •

edited by gregsheremeta

ovirt-infra commented Nov 8, 2018

gregsheremeta commented Nov 8, 2018

gregsheremeta Nov 8, 2018

bond95 Jan 16, 2019

bond95 Nov 12, 2018 •

edited

bond95 Nov 12, 2018 •

edited

kozloffsky Nov 12, 2018

gregsheremeta Nov 14, 2018

gregsheremeta Nov 14, 2018

bond95 Nov 15, 2018

gregsheremeta Nov 14, 2018

bond95 Nov 15, 2018

bond95 Nov 15, 2018

bond95 Nov 15, 2018

bond95 Nov 15, 2018

bond95 commented Jan 9, 2019

gregsheremeta commented Jan 9, 2019

gregsheremeta commented Jan 9, 2019

bond95 Jan 16, 2019

bond95 Jan 16, 2019

bond95 Jan 16, 2019

bond95 Jan 16, 2019

bond95 Jan 16, 2019

bond95 Jan 16, 2019

bond95 Jan 16, 2019

bond95 Jan 16, 2019

bond95 Jan 16, 2019

bond95 Jan 16, 2019

gregsheremeta commented Jan 18, 2019

gregsheremeta commented Jan 18, 2019

gregsheremeta commented Jan 30, 2019

gregsheremeta commented Jan 30, 2019

gregsheremeta commented Jan 30, 2019

gregsheremeta commented Feb 5, 2019

Add integration with vnc console #854

Add integration with vnc console #854

Conversation

kozloffsky commented Nov 8, 2018 • edited by gregsheremeta

ovirt-infra commented Nov 8, 2018

gregsheremeta commented Nov 8, 2018

Choose a reason for hiding this comment

Choose a reason for hiding this comment

bond95 Nov 12, 2018 • edited

Choose a reason for hiding this comment

bond95 Nov 12, 2018 • edited

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

bond95 commented Jan 9, 2019

gregsheremeta commented Jan 9, 2019

gregsheremeta commented Jan 9, 2019

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

gregsheremeta commented Jan 18, 2019

gregsheremeta commented Jan 18, 2019

gregsheremeta commented Jan 30, 2019

gregsheremeta commented Jan 30, 2019

gregsheremeta commented Jan 30, 2019

gregsheremeta commented Feb 5, 2019

kozloffsky commented Nov 8, 2018 •

edited by gregsheremeta

bond95 Nov 12, 2018 •

edited

bond95 Nov 12, 2018 •

edited