Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support web-based console connection #490

Closed
michalskrivanek opened this issue Feb 19, 2018 · 31 comments · Fixed by #956
Closed

Support web-based console connection #490

michalskrivanek opened this issue Feb 19, 2018 · 31 comments · Fixed by #956
Assignees
Labels
Flag: Bugzilla Issue or PR tracked on Bugzilla as well. use 'tracking_only' if there is no web-ui work to do Flag: Needs QE needs testing by QE team before merging PR and closing issue Flag: Needs UI review Needs UI designer to review screenshots before merging PR and closing issue Priority: High Work on these first Scope: 8+ 8 or more story points Status: ON_QA status ON_QA (currently being tested) Type: Enhancement an enhancement (i.e. not a bug)
Milestone

Comments

@michalskrivanek
Copy link
Member

michalskrivanek commented Feb 19, 2018

In addition to to .vv file we could support also web-based clients.

[(GS) edit: uses patternfly-react VncConsole ]

Designs: https://docs.google.com/document/d/1m-pM0VVgeZmVCJFs2lLuzC9KUVV-X1cDfLXPboMWuBA/edit

selection_265

selection_266

@michalskrivanek michalskrivanek added the Type: Enhancement an enhancement (i.e. not a bug) label Feb 19, 2018
@michalskrivanek michalskrivanek added this to the v1.4.0 milestone Feb 19, 2018
@matsimon
Copy link

Are there any plans on when oVirt or RHV are going to add this to the user-facing web-ui and not only in the webadmin side (where it actually works pretty well)?

@gregsheremeta
Copy link
Contributor

Quite soon. I'll reply back when I have an exact release date set.

@mareklibra
Copy link
Contributor

VncConsole component is merged in patternfly-react

@matsimon
Copy link

Oh, sweet, try to keep an eye on this issue, thanks for the update.

@gregsheremeta gregsheremeta modified the milestones: v1.4.0, v1.4.2 Jul 31, 2018
@gregsheremeta gregsheremeta self-assigned this Jul 31, 2018
@gregsheremeta
Copy link
Contributor

tentatively targeting to 1.4.2 (august 10). If I run into any issues, I'll push to 1.4.3 (august 24).

@gregsheremeta gregsheremeta changed the title [blocked] Support web-based console connection Support web-based console connection Jul 31, 2018
@gregsheremeta
Copy link
Contributor

out of time, pushing to 1.4.3. We scoped this one as quite difficult, so it might even slip to 1.4.4.

@gregsheremeta gregsheremeta modified the milestones: v1.4.2, v1.4.3 Aug 9, 2018
@gregsheremeta
Copy link
Contributor

@gregsheremeta
Copy link
Contributor

it might even slip to 1.4.4

indeed, now targeting 1.4.4

@gregsheremeta gregsheremeta modified the milestones: v1.4.3, v1.4.4 Aug 13, 2018
@michalskrivanek
Copy link
Member Author

I would expect it io take even longer

For reference, RHV tracking bug
https://bugzilla.redhat.com/show_bug.cgi?id=1615941

@michalskrivanek michalskrivanek added the Flag: Bugzilla Issue or PR tracked on Bugzilla as well. use 'tracking_only' if there is no web-ui work to do label Aug 15, 2018
@gregsheremeta
Copy link
Contributor

pushed to 1.5.0

@gregsheremeta gregsheremeta modified the milestones: v1.4.4, v1.5.0 Oct 11, 2018
@gregsheremeta gregsheremeta added Flag: Needs QE needs testing by QE team before merging PR and closing issue Priority: High Work on these first Scope: 8+ 8 or more story points Flag: Needs UI review Needs UI designer to review screenshots before merging PR and closing issue labels Jan 6, 2019
@timbogues
Copy link

Is there any update to this enhancement on when it will be available? This would definitely be a welcomed feature to my environment.

@gregsheremeta
Copy link
Contributor

This is our highest priority, and we are working on it now. See #854. Unfortunately it will miss oVirt 4.3.0, targeting to oVirt 4.3.2

@timbogues
Copy link

Is there an ETA on v4.3.2? Thank you for the quick response!

@gregsheremeta
Copy link
Contributor

roughly March, but don't quote me :)

bond95 added a commit to bond95/ovirt-web-ui that referenced this issue Feb 15, 2019
bond95 added a commit to bond95/ovirt-web-ui that referenced this issue Feb 20, 2019
bond95 added a commit to bond95/ovirt-web-ui that referenced this issue Mar 1, 2019
@gregsheremeta gregsheremeta added the Status: ON_QA status ON_QA (currently being tested) label Mar 5, 2019
@timbogues
Copy link

I saw v4.3.2 was released. Does this new version include the new web console feature?

@gregsheremeta
Copy link
Contributor

I saw v4.3.2 was released. Does this new version include the new web console feature?

Unfortunately, no. It's almost ready but we found some release blockers while testing.

You're welcome to try a pre-release though:
https://jenkins.ovirt.org/job/oVirt_ovirt-web-ui_standard-check-pr/489/artifact/check-patch.fc28.x86_64/ovirt-web-ui-1.5.2-0.20190318git5ee4e72.fc28.noarch.rpm

@gregsheremeta
Copy link
Contributor

Here's a screenshot of the rpm I linked above

Selection_043

@timbogues
Copy link

Ok, I'll start testing that out. Looks good!

bond95 added a commit to bond95/ovirt-web-ui that referenced this issue Apr 10, 2019
bond95 added a commit to bond95/ovirt-web-ui that referenced this issue Apr 18, 2019
@slobastev
Copy link

Is it going to work on Chromebooks?

@sjd78
Copy link
Member

sjd78 commented May 22, 2019

Is it going to work on Chromebooks?

I just confirmed that the webvnc console will work on a Chromebook. 👍 Just make sure you have the CA certificate from the welcome page installed for the websocket proxy to work properly.

@sjd78
Copy link
Member

sjd78 commented May 22, 2019

@lwrigh, @bond95, @michalskrivanek, @sgratch, @gregsheremeta - Do you guys remember if we ever discussed a full screen mode? When I tested from my smaller screened Chrome book, it looks a bit dense:
Screenshot 2019-05-22 at 6 20 29 PM

Screenshot 2019-05-22 at 6 31 14 PM

@lwrigh
Copy link

lwrigh commented May 23, 2019

Someone had suggested having a full screen option as a console setting which I think is a good idea. Especially on smaller resolution screens I think having a full screen option would really help to improve the visibility of the VM console.

@gregsheremeta
Copy link
Contributor

@lwrigh is correct. I don't think we ever wireframed it fully, but we should have it (probably via a new Issue 😁)

@lwrigh
Copy link

lwrigh commented May 23, 2019

I included a screen mode setting option in the console settings in the VM portal user settings wireframes (https://docs.google.com/document/d/1apA6E4zT21JSJgeO2V3Q_LhK9xq4SOwNeD-gIsG5pNY/edit?usp=sharing) if we want to cross references those issues.

@sjd78
Copy link
Member

sjd78 commented May 23, 2019

Someone had suggested having a full screen option as a console setting which I think is a good idea. Especially on smaller resolution screens I think having a full screen option would really help to improve the visibility of the VM console.

I'm not sure about it being a console setting. Maybe a console setting to "prefer full screen" or "default to full screen" mode is more appropriate. I'm just thinking a "full screen" button to hide the masthead, breadcrums and toolbar would return a decent portion of the page to the VNC console. Perhaps it would be more "full page" mode. Users could make the browser window full screen and then make the VNC console full page...

@lwrigh is correct. I don't think we ever wireframed it fully, but we should have it (probably via a new Issue 😁)

Agreed that a new issue to add a "full page" option or "hide toolbars" is a good step.

@lwrigh
Copy link

lwrigh commented May 28, 2019

@sjd78 Agreed, I think it makes total sense to have some sort of full screen mode button directly on the console page. Within the console settings having a full screen option as a default setting makes sense.

@nkovacne
Copy link

Which version of oVirt will have this feature added? As far as I could see, 4.3.4 doesn't contain it yet.

@michalskrivanek
Copy link
Member Author

@nkovacne There wasn't any ovirt-web-ui release yet. Once it's considered stable and tested. You are very welcome to help with providing feedback running the master ovirt-web-ui against your oVirt environment

@timbogues
Copy link

How can I install a pre-release version of oVirt Web UI that includes the web based VM console? Is there a place to download an RPM?

@sjd78
Copy link
Member

sjd78 commented Jun 25, 2019

How can I install a pre-release version of oVirt Web UI that includes the web based VM console? Is there a place to download an RPM?

The latest rpm build for master can be downloaded from the the ovirt-master-snapshot repo (click down based on your distro and version and ovirt-web-ui___.rpm will be in the noarch folder):

The nightly snapshot repos can be installed with https://resources.ovirt.org/pub/yum-repo/ovirt-release-master.rpm, but you'd need to be careful not to update other rpms.

@timbogues
Copy link

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Flag: Bugzilla Issue or PR tracked on Bugzilla as well. use 'tracking_only' if there is no web-ui work to do Flag: Needs QE needs testing by QE team before merging PR and closing issue Flag: Needs UI review Needs UI designer to review screenshots before merging PR and closing issue Priority: High Work on these first Scope: 8+ 8 or more story points Status: ON_QA status ON_QA (currently being tested) Type: Enhancement an enhancement (i.e. not a bug)
Projects
None yet
9 participants