Add auto_start flag to ovirt_vm resource #227
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
looks good, going to run the installation a few times with this patch. |
Gal-Zaidman
force-pushed
the
add-start-flag-to-vm
branch
2 times, most recently
from
b3f5c42
to
ba1c9c0
Compare
Gal-Zaidman
changed the title
liranr23
reviewed
Sep 13, 2020
Gal-Zaidman
force-pushed
the
add-start-flag-to-vm
branch
from
ba1c9c0
to
4b3dc1c
Compare
liranr23
approved these changes
Sep 13, 2020
The default behavior is that when we create a VM with the terraform provider the VM is automatically started. We want the ability to create a VM and not start it. Adding a flag to indicate if we want to start the VM on creation. Signed-off-by: Gal-Zaidman <gzaidman@redhat.com>
Gal-Zaidman
force-pushed
the
add-start-flag-to-vm
branch
from
4b3dc1c
to
ffd16ec
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The default behavior is that when we create a VM with the terraform provider the VM is automatically started.
We want the ability to create a VM and not start it.
Adding a flag to indicate if we want to start the VM on creation.
Signed-off-by: Gal-Zaidman gzaidman@redhat.com