Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug 1874747: ovirt: dont start the temp VM before template creation #4168

Merged
merged 1 commit into from Sep 14, 2020
Merged

Bug 1874747: ovirt: dont start the temp VM before template creation #4168

merged 1 commit into from Sep 14, 2020

Conversation

eslutsky
Copy link
Contributor

@eslutsky eslutsky commented Sep 13, 2020 •
edited

  • bump terraform provider with the auto_start param
  • add auto_start=false param to the installer not to start the VM when creating template.

this PR depends on oVirt/terraform-provider-ovirt#227
Signed-off-by: Evgeny Slutsky eslutsky@redhat.com

@openshift-ci-robot openshift-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. bugzilla/severity-urgent Referenced Bugzilla bug's severity is urgent for the branch this PR is targeting. labels Sep 13, 2020
@openshift-ci-robot
Copy link
Contributor

@eslutsky: This pull request references Bugzilla bug 1874747, which is valid. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.6.0) matches configured target release for branch (4.6.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

In response to this:

WIP: Bug 1874747: ovirt: dont start the temp VM before template creation

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added the bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. label Sep 13, 2020
@openshift-ci-robot
Copy link
Contributor

@eslutsky: This pull request references Bugzilla bug 1874747, which is valid.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.6.0) matches configured target release for branch (4.6.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

In response to this:

WIP: Bug 1874747: ovirt: dont start the temp VM before template creation

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@eslutsky eslutsky force-pushed the bump-terraform-provider branch 8 times, most recently from 87e3cc9 to 13dfc8e Compare September 14, 2020 11:11
Gal-Zaidman
Gal-Zaidman reviewed Sep 14, 2020
View reviewed changes
vendor/modules.txt Outdated Show resolved Hide resolved
Gal-Zaidman
Gal-Zaidman reviewed Sep 14, 2020
View reviewed changes
vendor/modules.txt Outdated Show resolved Hide resolved
@eslutsky eslutsky force-pushed the bump-terraform-provider branch 3 times, most recently from fad577a to 5253c37 Compare September 14, 2020 11:23
@openshift-ci-robot
Copy link
Contributor

@eslutsky: This pull request references Bugzilla bug 1874747, which is valid.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.6.0) matches configured target release for branch (4.6.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

In response to this:

WIP: Bug 1874747: ovirt: dont start the temp VM before template creation

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

1 similar comment
@openshift-ci-robot
Copy link
Contributor

@eslutsky: This pull request references Bugzilla bug 1874747, which is valid.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.6.0) matches configured target release for branch (4.6.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

In response to this:

WIP: Bug 1874747: ovirt: dont start the temp VM before template creation

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@eslutsky eslutsky changed the title WIP: Bug 1874747: ovirt: dont start the temp VM before template creation Bug 1874747: ovirt: dont start the temp VM before template creation Sep 14, 2020
@openshift-ci-robot openshift-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 14, 2020
@eslutsky
Bug 1874747: ovirt: dont start the temp VM before template creation
1125bb0 
- bump terraform provider with the required param
- add param to the installer not to start the VM when creating template.

Signed-off-by: Evgeny Slutsky <eslutsky@redhat.com>
@Gal-Zaidman
Copy link
Contributor

/test e2e-ovirt

@eslutsky
Copy link
Contributor Author

/assign @abhinavdahiya

@sdodson
Copy link
Member

sdodson commented Sep 14, 2020

/lgtm
/approve

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Sep 14, 2020
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sdodson

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 14, 2020
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Sep 14, 2020 •
edited

@eslutsky: The following test failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
ci/prow/e2e-crc 1125bb0 link /test e2e-crc

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-robot openshift-merge-robot merged commit 5edeb9c into openshift:master Sep 14, 2020
@openshift-ci-robot
Copy link
Contributor

@eslutsky: All pull requests linked via external trackers have merged:

Bugzilla bug 1874747 has been moved to the MODIFIED state.

In response to this:

Bug 1874747: ovirt: dont start the temp VM before template creation

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jstuever jstuever Awaiting requested review from jstuever

@Gal-Zaidman Gal-Zaidman Awaiting requested review from Gal-Zaidman

Assignees

@sdodson sdodson

@abhinavdahiya abhinavdahiya

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-urgent Referenced Bugzilla bug's severity is urgent for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@eslutsky @openshift-ci-robot @Gal-Zaidman @sdodson @openshift-bot @abhinavdahiya @openshift-merge-robot