Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove vdsm.common.compat module #55

Closed
nirs opened this issue Jan 30, 2022 · 0 comments · Fixed by #311
Closed

Remove vdsm.common.compat module #55

nirs opened this issue Jan 30, 2022 · 0 comments · Fixed by #311
Assignees
@tinez
Labels
cleanup Code change keeping current behavior good first issue Good issue for a new contributor infra

Comments

@nirs
Copy link
Member

nirs commented Jan 30, 2022 •
edited
Loading

This module was added to handle differences between python versions:

  • simplejson on RHEL 6.x
  • subprocess32 on python 2
  • missing glob.escape on python 2
  • using inspect.getargspec on python 2
  • handling missing modules on python 3

All these hacks are not needed for a while, so the module can be removed.

Dependnecies:

  • vdsm.storage.compat depending on vdsm.common.compat.MissingModule.

Depends: #56
@nirs nirs added the cleanup Code change keeping current behavior label Jan 30, 2022
This was referenced Jan 30, 2022
Closed
Merged
@nirs nirs added the infra label Mar 6, 2022
@nirs nirs added the good first issue Good issue for a new contributor label Mar 22, 2022
aesteve-rh added a commit to aesteve-rh/vdsm that referenced this issue Sep 8, 2022
@aesteve-rh
common.compat: remove module
f0381c3 
The remains in common.compat are:
- Unsupported class: barely used and easily
  interchangeable with ModuleNotFoundError
- MissingModule: placeholder class for
  missing modules, not used anymore, except
  for requires_sanlock mark decorator in
  the test infrastructure, but the decorator
  was not working anyway.
  Use pytest.importorskip instead.

Removing these remains allows us to completely
remove the compat module and drop all backwards
compatiblity workarounds.

Fixes: oVirt#55
Signed-off-by: Albert Esteve <aesteve@redhat.com>
@aesteve-rh aesteve-rh mentioned this issue Sep 8, 2022
Merged
aesteve-rh added a commit to aesteve-rh/vdsm that referenced this issue Sep 8, 2022
@aesteve-rh
common.compat: remove module
046d7b1 
The remains in common.compat are:
- Unsupported class: barely used and easily
  interchangeable with ModuleNotFoundError
- MissingModule: placeholder class for
  missing modules, not used anymore, except
  for requires_sanlock mark decorator in
  the test infrastructure, but the decorator
  was not working anyway.
  Use pytest.importorskip instead.

Removing these remains allows us to completely
remove the compat module and drop all backwards
compatiblity workarounds.

Fixes: oVirt#55
Signed-off-by: Albert Esteve <aesteve@redhat.com>
@nirs nirs closed this as completed in #311 Sep 12, 2022
nirs pushed a commit that referenced this issue Sep 12, 2022
@aesteve-rh @nirs
common.compat: remove module
f0db565 
The remains in common.compat are:
- Unsupported class: barely used and easily
  interchangeable with ModuleNotFoundError
- MissingModule: placeholder class for
  missing modules, not used anymore, except
  for requires_sanlock mark decorator in
  the test infrastructure, but the decorator
  was not working anyway.
  Use pytest.importorskip instead.

Removing these remains allows us to completely
remove the compat module and drop all backwards
compatiblity workarounds.

Fixes: #55
Signed-off-by: Albert Esteve <aesteve@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tinez tinez

Labels
cleanup Code change keeping current behavior good first issue Good issue for a new contributor infra
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove common.compat module aesteve-rh/vdsm
2 participants
@nirs @tinez