Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove vdsm.storage.compat module #56

Closed
nirs opened this issue Jan 30, 2022 · 0 comments · Fixed by #177
Closed

Remove vdsm.storage.compat module #56

nirs opened this issue Jan 30, 2022 · 0 comments · Fixed by #177
Assignees
@aesteve-rh
Labels
cleanup Code change keeping current behavior good first issue Good issue for a new contributor storage

Comments

@nirs
Copy link
Member

nirs commented Jan 30, 2022

This module added to deal with missing sanlock and ioprocess
in python 3, and with older versions of sanlock that use
async= instead of wait=.

These issues are not relevant for a while, so the module can be removed.

Blocks #55
@nirs nirs self-assigned this Jan 30, 2022
@nirs nirs mentioned this issue Jan 30, 2022
Closed
@nirs nirs added the cleanup Code change keeping current behavior label Jan 30, 2022
@nirs nirs added the storage label Mar 6, 2022
@nirs nirs added the good first issue Good issue for a new contributor label Mar 22, 2022
@nirs nirs removed their assignment Apr 19, 2022
@aesteve-rh aesteve-rh self-assigned this May 12, 2022
aesteve-rh added a commit to aesteve-rh/vdsm that referenced this issue May 13, 2022
@aesteve-rh
storage.compat: remove module
3dc099c 
This module used to handle missing ioprocess
and sanlock libraries in Python 3, and a workaround
to support sanlock older versions, that used 'async='
instead of to 'wait='.

However, it is not relevant anymore.

Fixes: oVirt#56
Signed-off-by: Albert Esteve <aesteve@redhat.com>
@aesteve-rh aesteve-rh mentioned this issue May 13, 2022
Merged
aesteve-rh added a commit to aesteve-rh/vdsm that referenced this issue May 16, 2022
@aesteve-rh
storage.compat: remove module
66d2bac 
This module used to handle missing ioprocess
and sanlock libraries in Python 3, and a workaround
to support sanlock older versions, that used 'async='
instead of to 'wait='.

However, it is not relevant anymore.

Fixes: oVirt#56
Signed-off-by: Albert Esteve <aesteve@redhat.com>
@nirs nirs closed this as completed in #177 May 16, 2022
nirs pushed a commit that referenced this issue May 16, 2022
@aesteve-rh @nirs
storage.compat: remove module
bec5e7c 
This module used to handle missing ioprocess
and sanlock libraries in Python 3, and a workaround
to support sanlock older versions, that used 'async='
instead of to 'wait='.

However, it is not relevant anymore.

Fixes: #56
Signed-off-by: Albert Esteve <aesteve@redhat.com>
erav pushed a commit to hbraha/vdsm that referenced this issue Jun 21, 2022
@aesteve-rh @erav
storage.compat: remove module
e5f7246 
This module used to handle missing ioprocess
and sanlock libraries in Python 3, and a workaround
to support sanlock older versions, that used 'async='
instead of to 'wait='.

However, it is not relevant anymore.

Fixes: oVirt#56
Signed-off-by: Albert Esteve <aesteve@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@aesteve-rh aesteve-rh

Labels
cleanup Code change keeping current behavior good first issue Good issue for a new contributor storage
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

storage.compat: remove module aesteve-rh/vdsm
2 participants
@nirs @aesteve-rh