Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

REST API changes for Hilary issue #1340 #34

Merged
merged 6 commits into from
Mar 22, 2017

Conversation

sallakarppinen
Copy link
Contributor

No description provided.

Copy link
Member

@brecke brecke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just that one thing fixed and it's ready to be merged.

lib/api.admin.js Outdated
* @param {User[]} callback.response The users for the given tenantAlias
*/
var getAllUsersForTenant = module.exports.getAllUsersForTenant = function(adminRestCtx, tenantAlias, callback) {
var url = '/api/tenant/' + RestUtil.encodeURIComponent(tenantAlias) + '/users';
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's make it tenants as plurals are the best and common practice.

Copy link
Member

@brecke brecke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ready to be merged

@sallakarppinen sallakarppinen merged commit aa290cb into oaeproject:master Mar 22, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants