Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feat] Client-go which is used to communicate with the managed-clusters can be configed with qps and burst #98

Open
oeular opened this issue May 13, 2022 · 4 comments
Open

[Feat] Client-go which is used to communicate with the managed-clusters can be configed with qps and burst #98

oeular opened this issue May 13, 2022 · 4 comments
Assignees
@oeular
Labels
enhancement New feature or request

Comments

@oeular
Copy link

oeular commented May 13, 2022

No description provided.

@oeular oeular changed the title [Feat] Client-go which is used to communicate with the managed-clusters can be config with qps and burst [Feat] Client-go which is used to communicate with the managed-clusters can be configed with qps and burst May 13, 2022
@oeular
Copy link
Author

oeular commented May 13, 2022

At the best, the configuration can be different for the managed clusters.

@yue9944882
Copy link
Member

@oeular sgtm, one feasible approach is to add the client-side rate-limit configurations under the spec of ClusterGateway (extending secrets via annotations). also, this feature should be gated according to its maturity. /cc @Somefive

@yue9944882 yue9944882 added the enhancement New feature or request label May 26, 2022
@oeular
Copy link
Author

oeular commented May 26, 2022

If the feature is not assigned, we want to join next month.

@Somefive
Copy link
Collaborator

Somefive commented Jun 8, 2022

This feature looks good to me. It's okay for @oeular to start.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@oeular oeular

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@yue9944882 @Somefive @oeular