Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: add virtual cluster #135

Merged
merged 1 commit into from
Apr 12, 2023
Merged

Conversation

Somefive
Copy link
Collaborator

Migrate https://github.com/kubevela/prism/tree/master/pkg/apis/cluster/v1alpha1 to here. Add "VirtualCluster" resource.

VirtualCluster is generally similar to ClusterGateway, except that

  1. It can additionally treat the hub control plane as the local cluster which does not provide extra cluster gateway access.
  2. It does not return the credential data for managed clusters while ClusterGateway resource returns that. This is to ensure only metadata can be achieved.
  3. The VirtualClusterClient can be used directly instead of calling the Aggregated API to access.
  4. Future extensions could be made to the VirtualClusterClient & VirtualCluster, like Create/Update/Delete.

Signed-off-by: Yin Da <yd219913@alibaba-inc.com>
Copy link
Collaborator

@chivalryq chivalryq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Somefive Somefive merged commit d966638 into oam-dev:master Apr 12, 2023
5 checks passed
@Somefive Somefive deleted the feat/virtualcluster branch April 12, 2023 03:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants