Fix iteration over os.environ from script worker and correctly strip prefixes #87
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andywaltlova
force-pushed
the
fix/dictionary-iteration-modiication
branch
from
bb74aa9
to
b0fcc18
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #87 +/- ##
=======================================
Coverage 98.56% 98.56%
=======================================
Files 1 1
Lines 348 349 +1
Branches 44 44
=======================================
+ Hits 343 344 +1
Misses 2 2
Partials 3 3
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
andywaltlova
force-pushed
the
fix/dictionary-iteration-modiication
branch
from
b0fcc18
to
3cb8079
Compare
…prefixes Signed-off-by: Andrea Waltlova <awaltlov@redhat.com>
andywaltlova
force-pushed
the
fix/dictionary-iteration-modiication
branch
from
3cb8079
to
7dbfdf9
Compare
r0x0d
approved these changes
Apr 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
HMS-4025
Creating new env for script run from environment passed from rhc-workr-script failed because we called pop during iteration.