Bug: using x-go-type-name results in missing types

[jamesphillpotts-fr]

This PR describes an issue with type generation when the x-go-type-name is used. The assigned type name is correctly used on the MyTestRequest but types for the enum type and the sub type that also has the x-go-type-name are missing.

[jamesphillpotts-fr]

I've managed to make my fix work with a couple of other tweaks to how schema types are used. All tests pass and all generated code tests remain the same except my new one which is fixed by this change.

[jamesphillpotts-fr]

Hi @jamietanna @deepmap-marcinr - if you get a minute, is there any chance of triggering the workflow for this PR so that I can make sure it's review-ready? Thanks :-)

[jamesphillpotts-fr]

Thanks @jamietanna, it seems to be ok 😌

[jamietanna]

Thanks for the changes - I'm not going to merge it just yet (and focus on getting the release out now) but will get this in for the next release, hopefully in a couple of weeks. Thanks!

[jamesphillpotts-fr]

@jamietanna are we able to get this merged now?

[jamesphillpotts-fr]

@jamietanna are we able to get this merged now?

bump :-)

[jamesphillpotts-fr]

Hi @jamietanna, just checking in on this PR - if there's anything you need me to do, please let me know.

[jamesphillpotts-fr]

Hi @jamietanna is there any chance if getting this PR moving again please?

[jamietanna]

Would you mind making sure the latest main branch is merged in? Can't see GitHub Actions having run.

I've got a day off tomorrow which I'm planning on spending a good chunk on oapi-codegen, so hopefully will get to this after #1254

[jamesphillpotts-fr]

No problem, I'll get onto that after some lunch :-)

[jamesphillpotts-fr]

@jamietanna all up to date, tests pass locally - please trigger the github actions when you get a chance :-)

[jamesphillpotts-fr]

Hi @jamietanna how did you get on with looking at this on Friday?

[jamietanna]

@jamesphillpotts-fr would you say that this PR should also close off #1354 ?

[jamesphillpotts-fr]

@jamietanna once x-go-type-name is added, I believe so, yes.

[jamietanna]

Thanks for your patience!