Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: filter by operation ids #929

Merged

Conversation

johanneswuerbach
Copy link
Contributor

@johanneswuerbach johanneswuerbach commented Jan 20, 2023

When generating server mocks or clients we often only need specific operations to be included. Right now we workaround this issue by having unique operation tags, but this has various side-effects.

Add the capability to include or exclude specific operations by their operation id inline with the existing support to filter by tags.

@johanneswuerbach johanneswuerbach force-pushed the filter-by-operation-ids branch 4 times, most recently from 3198861 to e678279 Compare June 5, 2023 18:54
@johanneswuerbach
Copy link
Contributor Author

johanneswuerbach commented Jun 5, 2023

I would also appreciate a look here @deepmap-marcinr and sorry about the spam :-( This is the last one, promise :-)

@johanneswuerbach
Copy link
Contributor Author

@deepmap-marcinr is this something, which would be acceptable for this repository? Happy to further elaborate on our use-case.

@jamietanna
Copy link
Member

Hey @johanneswuerbach thanks for raising! Would you mind adding an example of the usage under internal/test, just to show what it would look like + ensure we've got a test to catch regressions in the future

Once done, I'd say we can merge 😁

@jamietanna jamietanna added this to the v1.15.0 milestone Sep 2, 2023
@johanneswuerbach johanneswuerbach force-pushed the filter-by-operation-ids branch 2 times, most recently from 34efa3a to 255ac80 Compare September 3, 2023 17:22
@johanneswuerbach
Copy link
Contributor Author

Thanks for the review @jamietanna , integration tests added 👍

@johanneswuerbach
Copy link
Contributor Author

@jamietanna anything else I can support here? Thank you 🙇

@johanneswuerbach
Copy link
Contributor Author

@jamietanna I know you are busy, but I wondered if there is any chance to land this :-)

Copy link
Member

@jamietanna jamietanna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for this!

@jamietanna jamietanna merged commit d1b4504 into oapi-codegen:master Jan 25, 2024
8 checks passed
@jamietanna jamietanna added the enhancement New feature or request label Jan 25, 2024
@johanneswuerbach johanneswuerbach deleted the filter-by-operation-ids branch January 25, 2024 12:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants