Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

community selector cmp #219

Merged
merged 10 commits into from
Aug 26, 2024
Merged

Conversation

Ducica
Copy link
Contributor

@Ducica Ducica commented Aug 17, 2024

No description provided.

@Ducica Ducica marked this pull request as ready for review August 20, 2024 10:59
@Ducica Ducica requested a review from mirekys August 20, 2024 11:11
msgid "All records must belong to a community."
msgstr "Všechny záznamy musí patřit komunitě."

msgid "Go back"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Back -> Zpátky

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mirekys Hi, I replaced "go back" with "Home page, because I was using window object to basically pop the last entry and return to the last one (in a sense to return you to the page where you were previously), but I have come to realize that if you visit a form directly, by for example just pasting /_new url into the browser, when you click back it takes you back to your starting page i.e. google search, so I thought this was not ideal.

mirekys
mirekys previously approved these changes Aug 26, 2024
"please refer to the instructions on <6>how to join a community.</6> If you "
"are certain that you wish to proceed with the generic community, please "
"click on it below."
msgstr ""
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing translation

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mirekys A lot of these are just translations that are not used anymore, because make-translations, keeps the unused keys that were previously used, will try to remove manually

oarepo_ui/translations/cs/LC_MESSAGES/messages.po Outdated Show resolved Hide resolved
" po uložení nebude možné převést do jiné komunity."

msgid "Community landing page"
msgstr ""
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there some difference between landing page & home page?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mirekys unused key, will remove

msgstr "Domovská stránka komunity"

msgid "genericCommunityMessage"
msgstr ""
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why this text is translated 3x almost the same?

Copy link

sonarcloud bot commented Aug 26, 2024

@mirekys mirekys merged commit f72c382 into main Aug 26, 2024
3 checks passed
@mirekys mirekys deleted the stojanovic/fe-204-force-community-on-new-records branch August 26, 2024 10:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants