-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
community selector cmp #219
community selector cmp #219
Conversation
…ce-community-on-new-records
msgid "All records must belong to a community." | ||
msgstr "Všechny záznamy musí patřit komunitě." | ||
|
||
msgid "Go back" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Back -> Zpátky
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mirekys Hi, I replaced "go back" with "Home page, because I was using window object to basically pop the last entry and return to the last one (in a sense to return you to the page where you were previously), but I have come to realize that if you visit a form directly, by for example just pasting /_new url into the browser, when you click back it takes you back to your starting page i.e. google search, so I thought this was not ideal.
"please refer to the instructions on <6>how to join a community.</6> If you " | ||
"are certain that you wish to proceed with the generic community, please " | ||
"click on it below." | ||
msgstr "" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Missing translation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mirekys A lot of these are just translations that are not used anymore, because make-translations, keeps the unused keys that were previously used, will try to remove manually
" po uložení nebude možné převést do jiné komunity." | ||
|
||
msgid "Community landing page" | ||
msgstr "" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there some difference between landing page & home page?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mirekys unused key, will remove
msgstr "Domovská stránka komunity" | ||
|
||
msgid "genericCommunityMessage" | ||
msgstr "" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why this text is translated 3x almost the same?
...i/theme/assets/semantic-ui/js/oarepo_ui/forms/components/CommunitySelector/CommunityItem.jsx
Show resolved
Hide resolved
...eme/assets/semantic-ui/js/oarepo_ui/forms/components/CommunitySelector/CommunitySelector.jsx
Show resolved
Hide resolved
...eme/assets/semantic-ui/js/oarepo_ui/forms/components/CommunitySelector/CommunitySelector.jsx
Show resolved
Hide resolved
Quality Gate passedIssues Measures |
No description provided.