Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TAXIICollectionSource custom object handling fix #460

Merged
merged 1 commit into from
Sep 30, 2020

Conversation

emmanvg
Copy link
Contributor

@emmanvg emmanvg commented Sep 29, 2020

Resolves the unregistered custom object problem when a TAXII Server returns objects not registered on your local instance.

closes #459

@emmanvg emmanvg added this to the 2.1.0 milestone Sep 29, 2020
@codecov-commenter
Copy link

codecov-commenter commented Sep 29, 2020

Codecov Report

Merging #460 into master will decrease coverage by 8.99%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #460      +/-   ##
==========================================
- Coverage   98.24%   89.24%   -9.00%     
==========================================
  Files         142      142              
  Lines       15748    15748              
==========================================
- Hits        15471    14054    -1417     
- Misses        277     1694    +1417     
Impacted Files Coverage Δ
stix2/datastore/taxii.py 69.74% <100.00%> (-18.49%) ⬇️
stix2/version.py 0.00% <0.00%> (-100.00%) ⬇️
stix2/__init__.py 0.00% <0.00%> (-100.00%) ⬇️
stix2/v20/base.py 0.00% <0.00%> (-100.00%) ⬇️
stix2/v21/base.py 0.00% <0.00%> (-100.00%) ⬇️
stix2/v20/__init__.py 0.00% <0.00%> (-100.00%) ⬇️
stix2/v21/__init__.py 0.00% <0.00%> (-100.00%) ⬇️
stix2/v20/observables.py 21.71% <0.00%> (-78.29%) ⬇️
stix2/v21/observables.py 34.69% <0.00%> (-62.25%) ⬇️
stix2/v20/sdo.py 37.93% <0.00%> (-62.07%) ⬇️
... and 38 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3267036...7b35b82. Read the comment docs.

@clenk clenk merged commit edfcb16 into oasis-open:master Sep 30, 2020
@emmanvg emmanvg deleted the 459-issue branch September 30, 2020 14:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Access tactics of MITRE TaxiiServer results in AttributeError exception
3 participants