Refactor stix2.parsing into more focused modules #481
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- stix2.registry, which contains the class mapping structure and code for scanning stix2 modules for its initial population - stix2.registration, which contains code used to register custom STIX types with the registry - stix2.parsing, which contains code for creating instances of registered stix2 classes from raw dicts. This is intended to reduce circular import problems, by giving dependent code the ability to import a module which has exactly the functionality it needs, without pulling a lot of other stuff it doesn't need. Fewer imports means less chance of an import cycle.
top-level stix2 package to stix2.version but import it into stix2. This makes it possible for someone to get the symbol without needing to import all of stix2. Change an "import X" style import to "from X import Y" in stix2/__init__.py to be consistent with the other imports in that file.
Codecov Report
@@ Coverage Diff @@
## master #481 +/- ##
==========================================
- Coverage 89.32% 89.27% -0.05%
==========================================
Files 144 146 +2
Lines 16020 16032 +12
==========================================
+ Hits 14310 14313 +3
- Misses 1710 1719 +9
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactor stix2.parsing into more focused modules:
The motivation for this is to reduce the chances of circular import problems. The changes make it possible to import smaller modules with fewer dependencies. The changes could be backward-incompatible though, as it moves APIs around a bit.