Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Namespace upgrade #312

Merged
merged 5 commits into from Jul 23, 2021
Merged

Namespace upgrade #312

merged 5 commits into from Jul 23, 2021

Conversation

sthagen
Copy link
Contributor

@sthagen sthagen commented Jul 23, 2021

Added some plausible target namespace URLs for all three schema files - final URLs will be set collaborating with TC administration.

Closes #68.

@sthagen sthagen added enhancement documentation csaf 2.0 csaf 2.0 work editorial mostly nits and consistency labels Jul 23, 2021
@sthagen sthagen self-assigned this Jul 23, 2021
@sthagen sthagen added this to CSAF 2.0 JSON Schema Draft Work in CSAF 2.0 JSON Schema Draft Review via automation Jul 23, 2021
tschmidtb51
tschmidtb51 approved these changes Jul 23, 2021
View reviewed changes
Copy link
Contributor

@tschmidtb51 tschmidtb51 left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm. This will likely break my approach to #309 😞 (as schemas can't be retrieved on the fly anymore). But you are totally right! And it makes more sense to test the local ones (as the might introduce breaking changes...)

santosomar
santosomar approved these changes Jul 23, 2021
View reviewed changes
Copy link
Contributor

@santosomar santosomar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sthagen @tschmidtb51 Looks good, but quick question: since I own the CSAF.io domain, would you like to simplify the namespace URI?

@tschmidtb51
Copy link
Contributor

tschmidtb51 commented Jul 23, 2021 •
edited

@sthagen We also need that change for https://github.com/sthagen/csaf/blob/b6834b0e9414a6638631b7750cafbb3f0cc54a7f/csaf_2.0/examples/ROLIE/example-01-feed-tlp-white.json#L36

Edit: Now done through 930246d.

@tschmidtb51
Copy link
Contributor

@sthagen @tschmidtb51 Looks good, but quick question: since I own the CSAF.io domain, would you like to simplify the namespace URI?

No. We should stick to the official OASIS namespace.

But I would like to use https://csaf.io as namespace for the examples we provide in https://github.com/oasis-tcs/csaf/tree/master/csaf_2.0/test/validator/data

@santosomar
Copy link
Contributor

Sounds good. Thank you!

@santosomar santosomar merged commit 36cb60d into oasis-tcs:master Jul 23, 2021
tschmidtb51 added a commit to tschmidtb51/csaf that referenced this pull request Jul 23, 2021
@tschmidtb51
Namespace upgrade
930246d 
- addresses part of oasis-tcs#312 and oasis-tcs#313
- update namespace in ROLIE feed example
@tschmidtb51 tschmidtb51 mentioned this pull request Jul 23, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@santosomar santosomar santosomar approved these changes

@tschmidtb51 tschmidtb51 tschmidtb51 approved these changes

Assignees

@sthagen sthagen

Labels
csaf 2.0 csaf 2.0 work documentation editorial mostly nits and consistency enhancement
Projects
CSAF 2.0 JSON Schema Draft Review
  
CSAF 2.0 JSON Schema Draft Work
Milestone
CSAF 2.0 JSON Schema Draft Review
Development

Successfully merging this pull request may close these issues.

CSAF $id: link to OASIS namespacse
3 participants
@sthagen @tschmidtb51 @santosomar