Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ODATA-1630: Resharpened definitions of PropertyPath and NavigationPropertyPath #235

Merged
merged 4 commits into from Apr 10, 2024
Merged

ODATA-1630: Resharpened definitions of PropertyPath and NavigationPropertyPath #235

merged 4 commits into from Apr 10, 2024

Conversation

ralfhandl
Copy link
Contributor

@ralfhandl ralfhandl commented Jan 18, 2024 •
edited

Fixes #395

@ralfhandl ralfhandl mentioned this pull request Jan 18, 2024
Merged
HeikoTheissen
HeikoTheissen requested changes Jan 19, 2024
View reviewed changes
Copy link
Contributor

@HeikoTheissen HeikoTheissen left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The value of such a path must be a model element, and a term cast is not a model element but a path segment.
Replace "its instances" with "its value", because that covers single- and collection-valued.

odata-csdl/14 Vocabulary and Annotation.md Outdated Show resolved Hide resolved
odata-csdl/14 Vocabulary and Annotation.md Outdated Show resolved Hide resolved
@ralfhandl ralfhandl merged commit d1667f3 into main Apr 10, 2024
1 check passed
@ralfhandl ralfhandl deleted the ODATA-1630 branch April 10, 2024 15:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HeikoTheissen HeikoTheissen HeikoTheissen approved these changes

@mikepizzo mikepizzo Awaiting requested review from mikepizzo

@GEricson GEricson Awaiting requested review from GEricson

@chrisspre chrisspre Awaiting requested review from chrisspre

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Resharpen definitions of PropertyPath and NavigationPropertyPath
2 participants
@ralfhandl @HeikoTheissen