Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove Properties target, example (issues #389, 392) #401

Merged
merged 2 commits into from
Sep 7, 2022

Conversation

dlemire60
Copy link
Contributor

@dlemire60 dlemire60 commented Aug 16, 2022

Per issues #389 and #392 and discussion at the 8/10/2022 working meeting, this PR:

  1. removes Properties as a target from the table in 3.3.1.2
  2. removes the definition of the Properties target in 3.4.1.16
  3. renumbers 3.4.1.17 as 3.4.1.16
  4. removes the example use of the Properties target in C.3
  5. renumbers the subsections in C.4 as needed
  6. adds a tracking entry in the revision history in appendix E

EDIT: This is a breaking change, but it shouldn't affect any conformant implementation that only has Producer / Consumer interactions based on TC-developed APs.

@dlemire60 dlemire60 requested a review from davaya August 16, 2022 18:38
@dlemire60 dlemire60 changed the title remove Properties target, example remove Properties target, example (issues #389, 392) Aug 22, 2022
@dlemire60
Copy link
Contributor Author

Discussed at the 8/24/2022 working meeting.

Dave Kemp clarified that removing Properties is a breaking change, albeit one whose impact is low enough that this change could have been postponed if there weren't other breaking changes.

@dlemire60
Copy link
Contributor Author

Approved for merging at 7 September 2022 working meeting.

@dlemire60 dlemire60 merged commit 2bb3778 into oasis-tcs:working Sep 7, 2022
@dlemire60 dlemire60 deleted the issue-389-392 branch September 7, 2022 17:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant