Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename all 'instanceGuid' properties to 'guid' #341

Closed
michaelcfanning opened this issue Mar 12, 2019 · 2 comments
Closed

Rename all 'instanceGuid' properties to 'guid' #341

michaelcfanning opened this issue Mar 12, 2019 · 2 comments
Labels
2.1.0-CSD.1 Will be fixed in SARIF v2.1.0 CSD.1. design-approved The TC approved the design and I can write the change draft design-improvement e-ballot-2 impact-breaks-consumers impact-breaks-producers merged Changes merged into provisional draft. resolved-fixed sdk-code-complete tc-33 Issues to present at SARIF TC33

Comments

@michaelcfanning
Copy link
Contributor

No description provided.

@michaelcfanning michaelcfanning added the tc-33 Issues to present at SARIF TC33 label Mar 12, 2019
@ghost ghost added design-approved The TC approved the design and I can write the change draft 2.1.0-CSD.1 Will be fixed in SARIF v2.1.0 CSD.1. design-improvement labels Mar 13, 2019
@ghost ghost self-assigned this Mar 13, 2019
@michaelcfanning michaelcfanning mentioned this issue Mar 13, 2019
Closed
6 tasks
@ghost
Copy link

ghost commented Mar 13, 2019 •
edited by michaelcfanning

E-BALLOT PROPOSAL

SARIF defined several properties named "instanceGuid" to distinguish them from "logical GUIDs". There are no longer any "logical GUIDs" in the format, so simplify the names of these properties to "guid".

SCHEMA CHANGES

  • In the run object:

    • Rename the baselineInstanceGuid property to baselineGuid.
    • Rename the id property to automationDetails.
    • Rename the aggregateIds property to runAggregates

  • In the externalPropertyFile object (which is renamed to externalPropertyFileReference in #335):

    • Rename the instanceGuid property to guid.

  • In the runAutomationDetails object:

    • Rename the instanceId property to id.
    • Rename the baselineInstanceGuid property to baselineGuid

  • In the result object:

    • Rename the instanceGuid property to guid.

  • In the resultProvenance object:

    • Rename the firstDetectionRunInstanceGuid property to firstDetectionRunGuid.
    • Rename the lastDetectionRunInstanceGuid property to lastDetectionRunGuid.

  • In the externalProperties object:

    • Rename the instanceGuid property to guid.
    • Rename the runInstanceGuid property to runGuid.

ghost pushed a commit that referenced this issue Mar 13, 2019
Change draft for #341: instanceGuid property name changes.
9cf6824
ghost pushed a commit that referenced this issue Mar 13, 2019
Merge changes for #341: Rename instanceGuid properties.
68f0b17
@ghost ghost added the resolved-fixed label Mar 13, 2019
@ghost ghost closed this as completed Mar 13, 2019
ghost pushed a commit that referenced this issue Mar 13, 2019
#341: Sync change draft to provisional draft.
7fe01cb
@ghost ghost reopened this Mar 14, 2019
@ghost ghost added the merged Changes merged into provisional draft. label Mar 14, 2019
ghost pushed a commit that referenced this issue Mar 14, 2019
#341: Move change draft from Accepted to Active.
8da05e3
ghost pushed a commit that referenced this issue Mar 19, 2019
Provide "e-ballot #2" draft.
412c245 
This draft contains all the changes through "e-ballot #2," which
opened on Friday March 15 and will close on Friday March 22. It contains
changes for ballot issues #168, #291, #309, #320, #321, #326, #335,
and #341, as well as for previously approved issue #340.

It does _not_ contain changes for any issues from "e-ballot #3,"
which will open on Friday March 22 and close on Friday March 29.
@ghost
Copy link

ghost commented Mar 29, 2019

Approved in e-ballot #2.

@ghost ghost closed this as completed Mar 29, 2019
@ghost ghost mentioned this issue Apr 1, 2019
Closed
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
2.1.0-CSD.1 Will be fixed in SARIF v2.1.0 CSD.1. design-approved The TC approved the design and I can write the change draft design-improvement e-ballot-2 impact-breaks-consumers impact-breaks-producers merged Changes merged into provisional draft. resolved-fixed sdk-code-complete tc-33 Issues to present at SARIF TC33
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@michaelcfanning