Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Errata01 20230613 version: Example in K.3 has invalid key (typo, missing plural s for container) #589

Closed
sthagen opened this issue Jun 14, 2023 · 1 comment

Comments

@sthagen
Copy link
Contributor

sthagen commented Jun 14, 2023

During validation I noticed that the example in K.3 is invalid.

❯ diff -u minimal-recommended-without-source-info.json minimal-recommended-without-source-info-fixed.json
--- minimal-recommended-without-source-info.json	2023-06-14 19:20:53.000000000 +0200
+++ minimal-recommended-without-source-info-fixed.json	2023-06-14 20:19:25.000000000 +0200
@@ -7,7 +7,7 @@
           "name": "BinaryScanner"
         }
       },
-      "artifact": [
+      "artifacts": [
         {
           "location": {
             "uri": "bin/example",

I propose to NOT add this correction to Errata01!

Instead, I am OK with adding this defect to the Errata02 queue or oblivion ...

Rationale:

I sense some impatience (which I share!) in the TC to go forward and invest our resources into the next big thing (the minor release 2.2) instead of polishing the past.

sthagen added a commit to sthagen/oasis-tcs-sarif-spec that referenced this issue Jun 14, 2023
…le (oasis-tcs#589), and to ease testing the current errata01 jsin schema from 20230613
@dmk42
Copy link
Contributor

dmk42 commented Jun 19, 2023

Thanks. This has been incorporated into #568 .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants