Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

run.files keys can collide if specified by relative URLs #64

Closed
ghost opened this issue Oct 24, 2017 · 2 comments
Closed

run.files keys can collide if specified by relative URLs #64

ghost opened this issue Oct 24, 2017 · 2 comments

Comments

@ghost
Copy link

ghost commented Oct 24, 2017

If two files in the run.files dictionary have the same relative URL, but relative to different uriBaseIds, then they will collide (they will have the same key).

One option (suggested by @michaelcfanning) would be to allow the key to be constructed from uriBaseId + relative URL.

@ghost
Copy link
Author

ghost commented Jan 17, 2018

Accidentally closed the wrong issue.

@ghost ghost closed this as completed Jan 17, 2018
@ghost ghost reopened this Jan 17, 2018
@michaelcfanning michaelcfanning added the CSD.1 Will be fixed in CSD.1. label Feb 1, 2018
ghost pushed a commit that referenced this issue Mar 10, 2018
@ghost
Copy link
Author

ghost commented Mar 10, 2018

The solution we came up with is to encode the uriBaseId in the property name if necessary to avoid a property name collision, for example:

"files": {
  "#SRCROOT#utilities.c": {
    ...
  },
  "#TESTSRCROOT#utilities.cs": {
    ...
  }
}

ghost pushed a commit that referenced this issue Mar 17, 2018
@ghost ghost added the resolved-fixed label Mar 17, 2018
@ghost ghost self-assigned this Mar 17, 2018
@ghost ghost closed this as completed Mar 17, 2018
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant