content: reserve device IDs for video encoder and decoder device #67
Labels
virtio-v1.2-cs01
To be fixed in the next release.
Comments
|
BALLOT CREATED AT URL: https://www.oasis-open.org/committees/ballot.php?id=3468 |
|
Let me close this issue because the patch was merged. |
dgreid
pushed a commit
to dgreid/crosvm
that referenced
this issue
Feb 19, 2020
Stop using 30 and 31 as device IDs of virtio-wl and virtio-tpm, as these numbers were reserved for virtio-video devices in the upstream [1]. Instead, use integers from 63, which is the largest number we can use for a virtio device ID. Note that this CL must be merged after kernels with CL:2024135 landed. [1]: oasis-tcs/virtio-spec#67 BUG=chromium:1031512 TEST=Check if /dev/wl0 exists on ARCVM with CL:2024135 Change-Id: I267c7702d3c28642492f560170a0d1d9d6523c31 Signed-off-by: Keiichi Watanabe <keiichiw@chromium.org> Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/crosvm/+/2025127 Reviewed-by: Chirantan Ekbote <chirantan@chromium.org> Reviewed-by: Stephen Barber <smbarber@chromium.org> Commit-Queue: Fergus Dall <sidereal@google.com>
|
BALLOT CREATED AT URL: https://www.oasis-open.org/committees/ballot.php?id=3486 |
|
@mstsirkin Why did you create a new ballot again for this issue? You maybe intended #68 instead of here, didn't you? |
|
oh right. closing |
|
BALLOT CREATED AT URL: https://www.oasis-open.org/committees/ballot.php?id=3498 |
|
@mstsirkin Why did you create the ballot again? The patch was already merged. |
|
It keeps popping up because the commit lacked a Fixes tag. Sorry. |
joelagnel
pushed a commit
to joelagnel/linux-kernel
that referenced
this issue
Aug 9, 2022
Stop using 30 and 31 for virtio-wl and virtio-tpm, as these values are reserved for virtio-video devices [1]. Instead, we shift IDs for ChromeOS-specific devices to larger integers. We already use 62 in crosvm, we should also use the same number in the kernel driver. [1]: oasis-tcs/virtio-spec#67 BUG=b:227283268, chromium:1031512 TEST=Check the virtio TPM in crosvm Change-Id: I6f3a80ee371fce7a2d333bfb73819dc5ca32dcdd Signed-off-by: Yi Chou <yich@google.com> Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/third_party/kernel/+/3695731 Reviewed-by: Leo Lai <cylai@google.com> Reviewed-by: Keiichi Watanabe <keiichiw@chromium.org> (cherry picked from commit d6d17be) Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/third_party/kernel/+/3703044
disantkumar
pushed a commit
to disantkumar/intel-mainline-tracking
that referenced
this issue
Oct 16, 2023
Stop using 30 and 31 for virtio-wl and virtio-tpm, as these values are reserved for virtio-video devices [1]. Instead, we shift IDs for ChromeOS-specific devices to larger integers. We already use 62 in crosvm, we should also use the same number in the kernel driver. [1]: oasis-tcs/virtio-spec#67 BUG=b:227283268, chromium:1031512 TEST=Check the virtio TPM in crosvm Change-Id: I6f3a80ee371fce7a2d333bfb73819dc5ca32dcdd Signed-off-by: Yi Chou <yich@google.com> Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/third_party/kernel/+/3695731 Reviewed-by: Leo Lai <cylai@google.com> Reviewed-by: Keiichi Watanabe <keiichiw@chromium.org> (cherry picked from commit d6d17be4d257d22a98b3cd2513ae32036e6883f0) Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/third_party/kernel/+/3703044
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
The virtio-video protocol is for video encoder and decoder. (RFCv1, v2)
It needs two device IDs for decoder and encoder respectively.
We requested 30 and 31 in this patch, as 29 had been requested for hwsim wireless simulation.
https://lists.oasis-open.org/archives/virtio-comment/201912/msg00031.html
The text was updated successfully, but these errors were encountered: