This repository has been archived by the owner on Oct 6, 2021. It is now read-only.
Add custom section with version info to WASM #159
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The PR adds a custom section named
oasis_version
to each WASM. The contents are a JSON with keys "sha" (of the repo at the point when the service was built) and "serviceName" (intended for humans; derived from filename of wasm).The goal is to make it easier to debug the many version mismatches we have seen recently.
This change is backwards compatible.