Skip to content
This repository has been archived by the owner on Oct 6, 2021. It is now read-only.

Uniform node and browser module imports with rollup #25

Open
armaniferrante opened this issue May 4, 2019 · 2 comments
Open

Uniform node and browser module imports with rollup #25

armaniferrante opened this issue May 4, 2019 · 2 comments
Labels
p:3 Priority: nice to have

Comments

@armaniferrante
Copy link
Contributor

armaniferrante commented May 4, 2019

Currently, we have some utility modules that dispatch based based upon whether we're in a browser environment or not. We should be able to remove these by configuring Rollup to import the modules correctly.

For example, we we import tweetnacl like this with this file.

Also our EventEmitter imports need fixing (e.g., see #25), as they are causing us to use any types.

@armaniferrante armaniferrante added the p:3 Priority: nice to have label May 4, 2019
@armaniferrante
Copy link
Contributor Author

Mostly done by #73.

The last thing we should do here is replace this file with an import: https://github.com/oasislabs/oasis-client/blob/master/packages/confidential/src/tweetnacl.ts

@armaniferrante
Copy link
Contributor Author

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
p:3 Priority: nice to have
Projects
None yet
Development

No branches or pull requests

1 participant